diff --git a/desktop/scripts/build-plugin.ts b/desktop/scripts/build-plugin.ts index 8a60a1cef..79113b558 100644 --- a/desktop/scripts/build-plugin.ts +++ b/desktop/scripts/build-plugin.ts @@ -15,6 +15,7 @@ import {runBuild, computePackageChecksum} from 'flipper-pkg-lib'; import yargs from 'yargs'; import tmp from 'tmp'; import {execSync} from 'child_process'; +import {promisify} from 'util'; const argv = yargs .usage('yarn build-plugin [args]') @@ -89,7 +90,7 @@ async function buildPlugin() { : path.join(distDir, 'plugins', path.relative(pluginsDir, pluginDir)); await fs.ensureDir(path.dirname(outputFile)); await fs.remove(outputFile); - const {name: tmpDir} = tmp.dirSync(); + const tmpDir = await promisify(tmp.dir)(); const packageJsonBackupPath = path.join(tmpDir, 'package.json'); await fs.copy(packageJsonPath, packageJsonBackupPath, {overwrite: true}); try { diff --git a/desktop/scripts/bump-versions.ts b/desktop/scripts/bump-versions.ts index 8cfbd7a9c..77c32d50a 100644 --- a/desktop/scripts/bump-versions.ts +++ b/desktop/scripts/bump-versions.ts @@ -7,6 +7,8 @@ * @format */ +/* eslint-disable flipper/no-console-error-without-context */ + import {bumpVersions} from './workspaces'; import yargs from 'yargs'; diff --git a/desktop/scripts/compute-package-checksum.ts b/desktop/scripts/compute-package-checksum.ts index bf70de48d..bedec2cb8 100644 --- a/desktop/scripts/compute-package-checksum.ts +++ b/desktop/scripts/compute-package-checksum.ts @@ -7,6 +7,8 @@ * @format */ +/* eslint-disable flipper/no-console-error-without-context */ + import {computePackageChecksum} from 'flipper-pkg-lib'; import yargs from 'yargs'; diff --git a/desktop/scripts/gen-type-index.ts b/desktop/scripts/gen-type-index.ts index c763a4ab2..964a127be 100644 --- a/desktop/scripts/gen-type-index.ts +++ b/desktop/scripts/gen-type-index.ts @@ -6,6 +6,7 @@ * * @format */ +/* eslint-disable flipper/no-console-error-without-context */ import {rootDir} from './paths'; import path from 'path'; diff --git a/desktop/scripts/generate-plugin-entry-points.ts b/desktop/scripts/generate-plugin-entry-points.ts index eb3d4c0cf..67003250b 100644 --- a/desktop/scripts/generate-plugin-entry-points.ts +++ b/desktop/scripts/generate-plugin-entry-points.ts @@ -7,6 +7,8 @@ * @format */ +/* eslint-disable flipper/no-console-error-without-context */ + import {prepareDefaultPlugins} from './build-utils'; prepareDefaultPlugins().catch((err) => { diff --git a/desktop/scripts/get-app-watch-folders.ts b/desktop/scripts/get-app-watch-folders.ts index d60808b63..6d38da4ec 100644 --- a/desktop/scripts/get-app-watch-folders.ts +++ b/desktop/scripts/get-app-watch-folders.ts @@ -35,5 +35,5 @@ export default async function getAppWatchFolders() { } return watchFolders .filter((value, index, self) => self.indexOf(value) === index) - .filter(fs.pathExistsSync); + .filter(async (f) => fs.pathExists(f)); } diff --git a/desktop/scripts/isFB.js b/desktop/scripts/isFB.js index d4967b1c9..4f1a60e35 100644 --- a/desktop/scripts/isFB.js +++ b/desktop/scripts/isFB.js @@ -11,6 +11,8 @@ const fs = require('fs-extra'); const path = require('path'); +// Only used once at startup. +// eslint-disable-next-line node/no-sync const isFB = fs.pathExistsSync(path.resolve(__dirname, '..', 'static', 'fb')); module.exports = isFB; diff --git a/desktop/scripts/list-plugins.ts b/desktop/scripts/list-plugins.ts index ac4c9df84..be58a4dde 100644 --- a/desktop/scripts/list-plugins.ts +++ b/desktop/scripts/list-plugins.ts @@ -7,6 +7,8 @@ * @format */ +/* eslint-disable flipper/no-console-error-without-context */ + import {getWorkspaces} from './workspaces'; getWorkspaces() diff --git a/desktop/scripts/publish-packages.ts b/desktop/scripts/publish-packages.ts index e68696c36..191376bdf 100644 --- a/desktop/scripts/publish-packages.ts +++ b/desktop/scripts/publish-packages.ts @@ -7,6 +7,8 @@ * @format */ +/* eslint-disable flipper/no-console-error-without-context */ + import {publishPackages} from './workspaces'; import yargs from 'yargs'; diff --git a/desktop/scripts/resolve-plugin-dir.ts b/desktop/scripts/resolve-plugin-dir.ts index ee5a26ba6..40006f53f 100644 --- a/desktop/scripts/resolve-plugin-dir.ts +++ b/desktop/scripts/resolve-plugin-dir.ts @@ -7,6 +7,8 @@ * @format */ +/* eslint-disable flipper/no-console-error-without-context */ + import {resolvePluginDir} from './workspaces'; resolvePluginDir(process.argv[2]) diff --git a/desktop/scripts/start-dev-server.ts b/desktop/scripts/start-dev-server.ts index 2afd3f7d6..98e40c22b 100644 --- a/desktop/scripts/start-dev-server.ts +++ b/desktop/scripts/start-dev-server.ts @@ -383,6 +383,8 @@ function buildErrorScreen() { lines.push(err.message); lines.push( codeFrame( + // Part of a script, not blocking the UI loop. + // eslint-disable-next-line node/no-sync fs.readFileSync(err.filename, 'utf8'), err.lineNumber, err.column, diff --git a/desktop/scripts/tsc-plugins.ts b/desktop/scripts/tsc-plugins.ts index 1909ed78e..776c62494 100644 --- a/desktop/scripts/tsc-plugins.ts +++ b/desktop/scripts/tsc-plugins.ts @@ -7,6 +7,8 @@ * @format */ +/* eslint-disable flipper/no-console-error-without-context */ + import fs from 'fs-extra'; import path from 'path'; import {exec} from 'child_process';