jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove unused constructor arg from MainThreadFlipperReceiver

Browse Source 
Summary: Argument became unused in a previous diff.

Reviewed By: jknoxville

Differential Revision: D14642264

fbshipit-source-id: 99bc78a9cff8322e8bed337f201a4748039a0332
This commit is contained in:
Vlad Albulescu
2019-03-27 09:47:58 -07:00
committed by Facebook Github Bot
parent 153c75cfa9
commit 4d0b1d2fc3
5 changed files with 15 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
android/src/main/java/com/facebook/flipper/plugins/common/MainThreadFlipperReceiver.java
View File

@@ -9,7 +9,6 @@ package com.facebook.flipper.plugins.common;
import android.os.Handler; import android.os.Handler;
import android.os.Looper; import android.os.Looper;
import com.facebook.flipper.core.FlipperConnection;
import com.facebook.flipper.core.FlipperObject; import com.facebook.flipper.core.FlipperObject;
import com.facebook.flipper.core.FlipperReceiver; import com.facebook.flipper.core.FlipperReceiver;
import com.facebook.flipper.core.FlipperResponder; import com.facebook.flipper.core.FlipperResponder;
@@ -18,10 +17,6 @@ import java.io.StringWriter;
public abstract class MainThreadFlipperReceiver implements FlipperReceiver { public abstract class MainThreadFlipperReceiver implements FlipperReceiver {
public MainThreadFlipperReceiver(FlipperConnection connection) {
// TODO(T41065412): remove unused constructor argument.
}
private final Handler mHandler = new Handler(Looper.getMainLooper()); private final Handler mHandler = new Handler(Looper.getMainLooper());
@Override @Override

2
android/src/main/java/com/facebook/flipper/plugins/console/iface/ConsoleCommandReceiver.java
View File

@@ -39,7 +39,7 @@ public class ConsoleCommandReceiver {
final ScriptingSession session = scriptingEnvironment.startSession(); final ScriptingSession session = scriptingEnvironment.startSession();
final FlipperReceiver executeCommandReceiver = final FlipperReceiver executeCommandReceiver =
new MainThreadFlipperReceiver(connection) { new MainThreadFlipperReceiver() {
@Override @Override
public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder) public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder)
throws Exception { throws Exception {

24
android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java
View File

@@ -178,7 +178,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin {
} }
final FlipperReceiver mShouldShowLithoAccessibilitySettings = final FlipperReceiver mShouldShowLithoAccessibilitySettings =
new MainThreadFlipperReceiver(mConnection) { new MainThreadFlipperReceiver() {
@Override @Override
public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder) public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder)
throws Exception { throws Exception {
@@ -190,7 +190,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin {
}; };
final FlipperReceiver mGetRoot = final FlipperReceiver mGetRoot =
new MainThreadFlipperReceiver(mConnection) { new MainThreadFlipperReceiver() {
@Override @Override
public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder) public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder)
throws Exception { throws Exception {
@@ -199,7 +199,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin {
}; };
final FlipperReceiver mGetAXRoot = final FlipperReceiver mGetAXRoot =
new MainThreadFlipperReceiver(mConnection) { new MainThreadFlipperReceiver() {
@Override @Override
public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder) public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder)
throws Exception { throws Exception {
@@ -209,7 +209,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin {
} }
}; };
final FlipperReceiver mGetAllNodes = final FlipperReceiver mGetAllNodes =
new MainThreadFlipperReceiver(mConnection) { new MainThreadFlipperReceiver() {
@Override @Override
public void onReceiveOnMainThread( public void onReceiveOnMainThread(
final FlipperObject params, final FlipperResponder responder) throws Exception { final FlipperObject params, final FlipperResponder responder) throws Exception {
@@ -235,7 +235,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin {
}; };
final FlipperReceiver mGetNodes = final FlipperReceiver mGetNodes =
new MainThreadFlipperReceiver(mConnection) { new MainThreadFlipperReceiver() {
@Override @Override
public void onReceiveOnMainThread( public void onReceiveOnMainThread(
final FlipperObject params, final FlipperResponder responder) throws Exception { final FlipperObject params, final FlipperResponder responder) throws Exception {
@@ -280,7 +280,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin {
} }
final FlipperReceiver mGetAXNodes = final FlipperReceiver mGetAXNodes =
new MainThreadFlipperReceiver(mConnection) { new MainThreadFlipperReceiver() {
@Override @Override
public void onReceiveOnMainThread( public void onReceiveOnMainThread(
final FlipperObject params, final FlipperResponder responder) throws Exception { final FlipperObject params, final FlipperResponder responder) throws Exception {
@@ -330,7 +330,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin {
}; };
final FlipperReceiver mOnRequestAXFocus = final FlipperReceiver mOnRequestAXFocus =
new MainThreadFlipperReceiver(mConnection) { new MainThreadFlipperReceiver() {
@Override @Override
public void onReceiveOnMainThread( public void onReceiveOnMainThread(
final FlipperObject params, final FlipperResponder responder) throws Exception { final FlipperObject params, final FlipperResponder responder) throws Exception {
@@ -346,7 +346,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin {
}; };
final FlipperReceiver mSetData = final FlipperReceiver mSetData =
new MainThreadFlipperReceiver(mConnection) { new MainThreadFlipperReceiver() {
@Override @Override
public void onReceiveOnMainThread(final FlipperObject params, FlipperResponder responder) public void onReceiveOnMainThread(final FlipperObject params, FlipperResponder responder)
throws Exception { throws Exception {
@@ -377,7 +377,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin {
}; };
final FlipperReceiver mSetHighlighted = final FlipperReceiver mSetHighlighted =
new MainThreadFlipperReceiver(mConnection) { new MainThreadFlipperReceiver() {
@Override @Override
public void onReceiveOnMainThread(final FlipperObject params, FlipperResponder responder) public void onReceiveOnMainThread(final FlipperObject params, FlipperResponder responder)
throws Exception { throws Exception {
@@ -396,7 +396,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin {
}; };
final FlipperReceiver mSetSearchActive = final FlipperReceiver mSetSearchActive =
new MainThreadFlipperReceiver(mConnection) { new MainThreadFlipperReceiver() {
@Override @Override
public void onReceiveOnMainThread(final FlipperObject params, FlipperResponder responder) public void onReceiveOnMainThread(final FlipperObject params, FlipperResponder responder)
throws Exception { throws Exception {
@@ -426,7 +426,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin {
}; };
final FlipperReceiver mIsSearchActive = final FlipperReceiver mIsSearchActive =
new MainThreadFlipperReceiver(mConnection) { new MainThreadFlipperReceiver() {
@Override @Override
public void onReceiveOnMainThread(final FlipperObject params, FlipperResponder responder) public void onReceiveOnMainThread(final FlipperObject params, FlipperResponder responder)
throws Exception { throws Exception {
@@ -438,7 +438,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin {
}; };
final FlipperReceiver mGetSearchResults = final FlipperReceiver mGetSearchResults =
new MainThreadFlipperReceiver(mConnection) { new MainThreadFlipperReceiver() {
@Override @Override
public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder) public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder)
throws Exception { throws Exception {

2
android/src/main/java/com/facebook/flipper/plugins/litho/GenerateLithoAccessibilityRenderExtensionCommand.java
View File

@@ -30,7 +30,7 @@ public final class GenerateLithoAccessibilityRenderExtensionCommand
@Override @Override
public FlipperReceiver receiver(final ObjectTracker tracker, final FlipperConnection connection) { public FlipperReceiver receiver(final ObjectTracker tracker, final FlipperConnection connection) {
return new MainThreadFlipperReceiver(connection) { return new MainThreadFlipperReceiver() {
@Override @Override
public void onReceiveOnMainThread( public void onReceiveOnMainThread(
final FlipperObject params, final FlipperResponder responder) throws Exception { final FlipperObject params, final FlipperResponder responder) throws Exception {

5
android/src/test/java/com/facebook/flipper/plugins/common/MainThreadFlipperReceiverTest.java
View File

@@ -9,7 +9,6 @@ package com.facebook.flipper.plugins.common;
import com.facebook.flipper.core.FlipperObject; import com.facebook.flipper.core.FlipperObject;
import com.facebook.flipper.core.FlipperResponder; import com.facebook.flipper.core.FlipperResponder;
import com.facebook.flipper.testing.FlipperConnectionMock;
import com.facebook.flipper.testing.FlipperResponderMock; import com.facebook.flipper.testing.FlipperResponderMock;
import org.junit.Assert; import org.junit.Assert;
import org.junit.Before; import org.junit.Before;
@@ -20,19 +19,17 @@ import org.robolectric.RobolectricTestRunner;
@RunWith(RobolectricTestRunner.class) @RunWith(RobolectricTestRunner.class)
public class MainThreadFlipperReceiverTest { public class MainThreadFlipperReceiverTest {
FlipperConnectionMock connection;
FlipperResponderMock responder; FlipperResponderMock responder;
@Before @Before
public void setup() throws Exception { public void setup() throws Exception {
connection = new FlipperConnectionMock();
responder = new FlipperResponderMock(); responder = new FlipperResponderMock();
} }
@Test @Test
public void errorIsPassedToResponder() throws Exception { public void errorIsPassedToResponder() throws Exception {
MainThreadFlipperReceiver receiver = MainThreadFlipperReceiver receiver =
new MainThreadFlipperReceiver(connection) { new MainThreadFlipperReceiver() {
public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder) public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder)
throws Exception { throws Exception {
throw new RuntimeException("hello exception"); throw new RuntimeException("hello exception");