diff --git a/android/src/main/java/com/facebook/flipper/plugins/common/MainThreadFlipperReceiver.java b/android/src/main/java/com/facebook/flipper/plugins/common/MainThreadFlipperReceiver.java index 91ad6c19f..a1d7b8070 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/common/MainThreadFlipperReceiver.java +++ b/android/src/main/java/com/facebook/flipper/plugins/common/MainThreadFlipperReceiver.java @@ -9,7 +9,6 @@ package com.facebook.flipper.plugins.common; import android.os.Handler; import android.os.Looper; -import com.facebook.flipper.core.FlipperConnection; import com.facebook.flipper.core.FlipperObject; import com.facebook.flipper.core.FlipperReceiver; import com.facebook.flipper.core.FlipperResponder; @@ -18,10 +17,6 @@ import java.io.StringWriter; public abstract class MainThreadFlipperReceiver implements FlipperReceiver { - public MainThreadFlipperReceiver(FlipperConnection connection) { - // TODO(T41065412): remove unused constructor argument. - } - private final Handler mHandler = new Handler(Looper.getMainLooper()); @Override diff --git a/android/src/main/java/com/facebook/flipper/plugins/console/iface/ConsoleCommandReceiver.java b/android/src/main/java/com/facebook/flipper/plugins/console/iface/ConsoleCommandReceiver.java index 4f356d6f7..e925f4d1c 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/console/iface/ConsoleCommandReceiver.java +++ b/android/src/main/java/com/facebook/flipper/plugins/console/iface/ConsoleCommandReceiver.java @@ -39,7 +39,7 @@ public class ConsoleCommandReceiver { final ScriptingSession session = scriptingEnvironment.startSession(); final FlipperReceiver executeCommandReceiver = - new MainThreadFlipperReceiver(connection) { + new MainThreadFlipperReceiver() { @Override public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder) throws Exception { diff --git a/android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java b/android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java index a9794e894..1a7a2d0c6 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java +++ b/android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java @@ -178,7 +178,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin { } final FlipperReceiver mShouldShowLithoAccessibilitySettings = - new MainThreadFlipperReceiver(mConnection) { + new MainThreadFlipperReceiver() { @Override public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder) throws Exception { @@ -190,7 +190,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin { }; final FlipperReceiver mGetRoot = - new MainThreadFlipperReceiver(mConnection) { + new MainThreadFlipperReceiver() { @Override public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder) throws Exception { @@ -199,7 +199,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin { }; final FlipperReceiver mGetAXRoot = - new MainThreadFlipperReceiver(mConnection) { + new MainThreadFlipperReceiver() { @Override public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder) throws Exception { @@ -209,7 +209,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin { } }; final FlipperReceiver mGetAllNodes = - new MainThreadFlipperReceiver(mConnection) { + new MainThreadFlipperReceiver() { @Override public void onReceiveOnMainThread( final FlipperObject params, final FlipperResponder responder) throws Exception { @@ -235,7 +235,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin { }; final FlipperReceiver mGetNodes = - new MainThreadFlipperReceiver(mConnection) { + new MainThreadFlipperReceiver() { @Override public void onReceiveOnMainThread( final FlipperObject params, final FlipperResponder responder) throws Exception { @@ -280,7 +280,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin { } final FlipperReceiver mGetAXNodes = - new MainThreadFlipperReceiver(mConnection) { + new MainThreadFlipperReceiver() { @Override public void onReceiveOnMainThread( final FlipperObject params, final FlipperResponder responder) throws Exception { @@ -330,7 +330,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin { }; final FlipperReceiver mOnRequestAXFocus = - new MainThreadFlipperReceiver(mConnection) { + new MainThreadFlipperReceiver() { @Override public void onReceiveOnMainThread( final FlipperObject params, final FlipperResponder responder) throws Exception { @@ -346,7 +346,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin { }; final FlipperReceiver mSetData = - new MainThreadFlipperReceiver(mConnection) { + new MainThreadFlipperReceiver() { @Override public void onReceiveOnMainThread(final FlipperObject params, FlipperResponder responder) throws Exception { @@ -377,7 +377,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin { }; final FlipperReceiver mSetHighlighted = - new MainThreadFlipperReceiver(mConnection) { + new MainThreadFlipperReceiver() { @Override public void onReceiveOnMainThread(final FlipperObject params, FlipperResponder responder) throws Exception { @@ -396,7 +396,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin { }; final FlipperReceiver mSetSearchActive = - new MainThreadFlipperReceiver(mConnection) { + new MainThreadFlipperReceiver() { @Override public void onReceiveOnMainThread(final FlipperObject params, FlipperResponder responder) throws Exception { @@ -426,7 +426,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin { }; final FlipperReceiver mIsSearchActive = - new MainThreadFlipperReceiver(mConnection) { + new MainThreadFlipperReceiver() { @Override public void onReceiveOnMainThread(final FlipperObject params, FlipperResponder responder) throws Exception { @@ -438,7 +438,7 @@ public class InspectorFlipperPlugin implements FlipperPlugin { }; final FlipperReceiver mGetSearchResults = - new MainThreadFlipperReceiver(mConnection) { + new MainThreadFlipperReceiver() { @Override public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder) throws Exception { diff --git a/android/src/main/java/com/facebook/flipper/plugins/litho/GenerateLithoAccessibilityRenderExtensionCommand.java b/android/src/main/java/com/facebook/flipper/plugins/litho/GenerateLithoAccessibilityRenderExtensionCommand.java index e511246db..4d8c28d46 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/litho/GenerateLithoAccessibilityRenderExtensionCommand.java +++ b/android/src/main/java/com/facebook/flipper/plugins/litho/GenerateLithoAccessibilityRenderExtensionCommand.java @@ -30,7 +30,7 @@ public final class GenerateLithoAccessibilityRenderExtensionCommand @Override public FlipperReceiver receiver(final ObjectTracker tracker, final FlipperConnection connection) { - return new MainThreadFlipperReceiver(connection) { + return new MainThreadFlipperReceiver() { @Override public void onReceiveOnMainThread( final FlipperObject params, final FlipperResponder responder) throws Exception { diff --git a/android/src/test/java/com/facebook/flipper/plugins/common/MainThreadFlipperReceiverTest.java b/android/src/test/java/com/facebook/flipper/plugins/common/MainThreadFlipperReceiverTest.java index a9aab982a..e3b62a9a7 100644 --- a/android/src/test/java/com/facebook/flipper/plugins/common/MainThreadFlipperReceiverTest.java +++ b/android/src/test/java/com/facebook/flipper/plugins/common/MainThreadFlipperReceiverTest.java @@ -9,7 +9,6 @@ package com.facebook.flipper.plugins.common; import com.facebook.flipper.core.FlipperObject; import com.facebook.flipper.core.FlipperResponder; -import com.facebook.flipper.testing.FlipperConnectionMock; import com.facebook.flipper.testing.FlipperResponderMock; import org.junit.Assert; import org.junit.Before; @@ -20,19 +19,17 @@ import org.robolectric.RobolectricTestRunner; @RunWith(RobolectricTestRunner.class) public class MainThreadFlipperReceiverTest { - FlipperConnectionMock connection; FlipperResponderMock responder; @Before public void setup() throws Exception { - connection = new FlipperConnectionMock(); responder = new FlipperResponderMock(); } @Test public void errorIsPassedToResponder() throws Exception { MainThreadFlipperReceiver receiver = - new MainThreadFlipperReceiver(connection) { + new MainThreadFlipperReceiver() { public void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder) throws Exception { throw new RuntimeException("hello exception");