jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Implemented menu to select ide

Browse Source 
Summary:
Added IDE menu functionalities.
Changed minor UX detail - for classes that cannot be opened user will always see 'Can't open' prompt.

Design: https://www.figma.com/file/M0l6qhQqzllIcefVE4tQvG/Error-Reporter-IDE-Selector?node-id=82%3A0

Reviewed By: arpitratan, adityasharat

Differential Revision: D22790328

fbshipit-source-id: 8dfbcf7408c53947909bcf3fa700dee7ae47e14a
This commit is contained in:
Dominik Wielgórski
2020-07-30 04:28:27 -07:00
committed by Facebook GitHub Bot
parent a37d48d67e
commit 4c4097f0f8
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java
View File

@@ -447,9 +447,9 @@ public class InspectorFlipperPlugin implements FlipperPlugin {
return mConnection != null; return mConnection != null;
} }
public boolean openInIDE( public void openInIDE(
String fileName, String className, String dirRoot, String repo, int lineNumber, IDE ide) { String fileName, String className, String dirRoot, String repo, int lineNumber, IDE ide) {
if (mConnection == null) return false; if (mConnection == null) return;
mConnection.send( mConnection.send(
"openInIDE", "openInIDE",
@@ -461,7 +461,6 @@ public class InspectorFlipperPlugin implements FlipperPlugin {
.put("lineNumber", lineNumber) .put("lineNumber", lineNumber)
.put("ide", ide) .put("ide", ide)
.build()); .build());
return true;
} }
private void setHighlighted( private void setHighlighted(