From 4c4097f0f832f7a807949ae35be5a8ca6945486d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20Wielg=C3=B3rski?= Date: Thu, 30 Jul 2020 04:28:27 -0700 Subject: [PATCH] Implemented menu to select ide Summary: Added IDE menu functionalities. Changed minor UX detail - for classes that cannot be opened user will always see 'Can't open' prompt. Design: https://www.figma.com/file/M0l6qhQqzllIcefVE4tQvG/Error-Reporter-IDE-Selector?node-id=82%3A0 Reviewed By: arpitratan, adityasharat Differential Revision: D22790328 fbshipit-source-id: 8dfbcf7408c53947909bcf3fa700dee7ae47e14a --- .../flipper/plugins/inspector/InspectorFlipperPlugin.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java b/android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java index e205a0324..cf98d730f 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java +++ b/android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java @@ -447,9 +447,9 @@ public class InspectorFlipperPlugin implements FlipperPlugin { return mConnection != null; } - public boolean openInIDE( + public void openInIDE( String fileName, String className, String dirRoot, String repo, int lineNumber, IDE ide) { - if (mConnection == null) return false; + if (mConnection == null) return; mConnection.send( "openInIDE", @@ -461,7 +461,6 @@ public class InspectorFlipperPlugin implements FlipperPlugin { .put("lineNumber", lineNumber) .put("ide", ide) .build()); - return true; } private void setHighlighted(