jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Electron releases do not update indicator on the Navigation Bar

Browse Source 
Summary: No need to show this for Electron releases. Also, this becomes important once we make the final Electron release.

Reviewed By: aigoncharov

Differential Revision: D50557052

fbshipit-source-id: 803a9c9ad21fbff39147ac06add74888b9ee4091
This commit is contained in:
Lorenzo Blasa
2023-10-24 05:51:06 -07:00
committed by Facebook GitHub Bot
parent 21057fba01
commit 4b915da47c
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
desktop/flipper-ui-core/src/dispatcher/handleOpenPluginDeeplink.tsx
View File

@@ -291,10 +291,11 @@ async function waitForLogin(store: Store) {
async function verifyFlipperIsUpToDate(title: string) { async function verifyFlipperIsUpToDate(title: string) {
const serverConfig = getRenderHostInstance().serverConfig; const serverConfig = getRenderHostInstance().serverConfig;
// // If this is not a headless build, do not check for updates.
// if (!serverConfig.environmentInfo.isHeadlessBuild) { // If this is not a headless build, do not check for updates.
// return; if (!serverConfig.environmentInfo.isHeadlessBuild) {
// } return;
}
const config = serverConfig.processConfig; const config = serverConfig.processConfig;
if ( if (
!isProduction() || !isProduction() ||

3
desktop/flipper-ui-core/src/sandy-chrome/Navbar.tsx
View File

@@ -103,7 +103,8 @@ export const Navbar = withTrackingScope(function Navbar() {
<TroubleshootMenu /> <TroubleshootMenu />
<ExtrasMenu /> <ExtrasMenu />
<RightSidebarToggleButton /> <RightSidebarToggleButton />
<UpdateIndicator /> {getRenderHostInstance().serverConfig.environmentInfo
.isHeadlessBuild && <UpdateIndicator />}
</Layout.Horizontal> </Layout.Horizontal>
</Layout.Horizontal> </Layout.Horizontal>
); );