From 4b915da47c1a7bb179e0137c55a3457b37dac3c7 Mon Sep 17 00:00:00 2001 From: Lorenzo Blasa Date: Tue, 24 Oct 2023 05:51:06 -0700 Subject: [PATCH] Electron releases do not update indicator on the Navigation Bar Summary: No need to show this for Electron releases. Also, this becomes important once we make the final Electron release. Reviewed By: aigoncharov Differential Revision: D50557052 fbshipit-source-id: 803a9c9ad21fbff39147ac06add74888b9ee4091 --- .../src/dispatcher/handleOpenPluginDeeplink.tsx | 9 +++++---- desktop/flipper-ui-core/src/sandy-chrome/Navbar.tsx | 3 ++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/desktop/flipper-ui-core/src/dispatcher/handleOpenPluginDeeplink.tsx b/desktop/flipper-ui-core/src/dispatcher/handleOpenPluginDeeplink.tsx index 48ec33258..68d56c79f 100644 --- a/desktop/flipper-ui-core/src/dispatcher/handleOpenPluginDeeplink.tsx +++ b/desktop/flipper-ui-core/src/dispatcher/handleOpenPluginDeeplink.tsx @@ -291,10 +291,11 @@ async function waitForLogin(store: Store) { async function verifyFlipperIsUpToDate(title: string) { const serverConfig = getRenderHostInstance().serverConfig; - // // If this is not a headless build, do not check for updates. - // if (!serverConfig.environmentInfo.isHeadlessBuild) { - // return; - // } + + // If this is not a headless build, do not check for updates. + if (!serverConfig.environmentInfo.isHeadlessBuild) { + return; + } const config = serverConfig.processConfig; if ( !isProduction() || diff --git a/desktop/flipper-ui-core/src/sandy-chrome/Navbar.tsx b/desktop/flipper-ui-core/src/sandy-chrome/Navbar.tsx index 4327b7bf9..8e4023c1c 100644 --- a/desktop/flipper-ui-core/src/sandy-chrome/Navbar.tsx +++ b/desktop/flipper-ui-core/src/sandy-chrome/Navbar.tsx @@ -103,7 +103,8 @@ export const Navbar = withTrackingScope(function Navbar() { - + {getRenderHostInstance().serverConfig.environmentInfo + .isHeadlessBuild && } );