Simpler win sign exception
Summary: We're skipping the signing and editing of EXEs on Windows. This is only temporary but I want to have an atomic commit we can go back to. This is to avoid cache eviction due to version numbers being encoded in the binary. This means you're not getting the logo on the binary and copyright information, etc. We're not actually shipping these right now, so the real-world impact of this is zero. Reviewed By: mweststrate Differential Revision: D25973944 fbshipit-source-id: d076919acfaac1f618178294baff3e9122d820bf
This commit is contained in:
committed by
Facebook GitHub Bot
parent
f6087cf765
commit
4a8e98733d
@@ -194,6 +194,9 @@ async function buildDist(buildFolder: string) {
|
||||
mac: {
|
||||
bundleVersion: '50.0.0',
|
||||
},
|
||||
win: {
|
||||
signAndEditExecutable: !isFB,
|
||||
},
|
||||
},
|
||||
projectDir: buildFolder,
|
||||
targets,
|
||||
|
||||
Reference in New Issue
Block a user