From 4a8e98733d5e2fe00a93347a5a0b8475ea44f79b Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Wed, 20 Jan 2021 09:12:14 -0800 Subject: [PATCH] Simpler win sign exception Summary: We're skipping the signing and editing of EXEs on Windows. This is only temporary but I want to have an atomic commit we can go back to. This is to avoid cache eviction due to version numbers being encoded in the binary. This means you're not getting the logo on the binary and copyright information, etc. We're not actually shipping these right now, so the real-world impact of this is zero. Reviewed By: mweststrate Differential Revision: D25973944 fbshipit-source-id: d076919acfaac1f618178294baff3e9122d820bf --- desktop/scripts/build-release.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/desktop/scripts/build-release.ts b/desktop/scripts/build-release.ts index 696bd0156..2f0c78a81 100755 --- a/desktop/scripts/build-release.ts +++ b/desktop/scripts/build-release.ts @@ -194,6 +194,9 @@ async function buildDist(buildFolder: string) { mac: { bundleVersion: '50.0.0', }, + win: { + signAndEditExecutable: !isFB, + }, }, projectDir: buildFolder, targets,