jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix UI freezes on popup opening by upgrading back React app creation from "createRoot" to "ReactDOM.render"

Browse Source 
Summary: Fix UI freezes on popup opening by upgrading back React app creation from "createRoot" to "ReactDOM.render". These UI freezes started to happen after React upgrade because the issue in integration of Antd with React 18: https://github.com/react-component/trigger/issues/288

Reviewed By: aigoncharov

Differential Revision: D35359129

fbshipit-source-id: eb0ad979443ecf67eb2acc2e219196c9fefcff62
This commit is contained in:
Anton Nikolaev
2022-04-04 08:00:06 -07:00
committed by Facebook GitHub Bot
parent 86dc5b13fc
commit 46340fa30a
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
desktop/flipper-ui-core/src/startFlipperDesktop.tsx
View File

@@ -44,6 +44,7 @@ import {getRenderHostInstance} from './RenderHost';
import {startGlobalErrorHandling} from './utils/globalErrorHandling'; import {startGlobalErrorHandling} from './utils/globalErrorHandling';
import {loadTheme} from './utils/loadTheme'; import {loadTheme} from './utils/loadTheme';
import {connectFlipperServerToStore} from './dispatcher/flipperServer'; import {connectFlipperServerToStore} from './dispatcher/flipperServer';
import ReactDOM from 'react-dom';
class AppFrame extends React.Component< class AppFrame extends React.Component<
{logger: Logger; persistor: Persistor}, {logger: Logger; persistor: Persistor},
@@ -164,8 +165,14 @@ function init(flipperServer: FlipperServer) {
connectFlipperServerToStore(flipperServer, store, logger); connectFlipperServerToStore(flipperServer, store, logger);
const root = createRoot(document.getElementById('root')!); // TODO T116224873: Return the following code back instead of ReactDOM.react when the following issue is fixed: https://github.com/react-component/trigger/issues/288
root.render(<AppFrame logger={logger} persistor={persistor} />); // const root = createRoot(document.getElementById('root')!);
// root.render(<AppFrame logger={logger} persistor={persistor} />);
ReactDOM.render(
<AppFrame logger={logger} persistor={persistor} />,
document.getElementById('root')!,
);
enableConsoleHook(); enableConsoleHook();