From 46340fa30a1d77b74b6d13254645b52e76b05c8c Mon Sep 17 00:00:00 2001 From: Anton Nikolaev Date: Mon, 4 Apr 2022 08:00:06 -0700 Subject: [PATCH] Fix UI freezes on popup opening by upgrading back React app creation from "createRoot" to "ReactDOM.render" Summary: Fix UI freezes on popup opening by upgrading back React app creation from "createRoot" to "ReactDOM.render". These UI freezes started to happen after React upgrade because the issue in integration of Antd with React 18: https://github.com/react-component/trigger/issues/288 Reviewed By: aigoncharov Differential Revision: D35359129 fbshipit-source-id: eb0ad979443ecf67eb2acc2e219196c9fefcff62 --- desktop/flipper-ui-core/src/startFlipperDesktop.tsx | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/desktop/flipper-ui-core/src/startFlipperDesktop.tsx b/desktop/flipper-ui-core/src/startFlipperDesktop.tsx index fdde85ddc..56995fd0f 100644 --- a/desktop/flipper-ui-core/src/startFlipperDesktop.tsx +++ b/desktop/flipper-ui-core/src/startFlipperDesktop.tsx @@ -44,6 +44,7 @@ import {getRenderHostInstance} from './RenderHost'; import {startGlobalErrorHandling} from './utils/globalErrorHandling'; import {loadTheme} from './utils/loadTheme'; import {connectFlipperServerToStore} from './dispatcher/flipperServer'; +import ReactDOM from 'react-dom'; class AppFrame extends React.Component< {logger: Logger; persistor: Persistor}, @@ -164,8 +165,14 @@ function init(flipperServer: FlipperServer) { connectFlipperServerToStore(flipperServer, store, logger); - const root = createRoot(document.getElementById('root')!); - root.render(); + // TODO T116224873: Return the following code back instead of ReactDOM.react when the following issue is fixed: https://github.com/react-component/trigger/issues/288 + // const root = createRoot(document.getElementById('root')!); + // root.render(); + + ReactDOM.render( + , + document.getElementById('root')!, + ); enableConsoleHook();