jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use correct bounds for litho debug components

Browse Source 
Summary:
This change is a follow-up on Litho release:
https://central.sonatype.dev/artifact/com.facebook.litho/litho-widget-kotlin/0.44.0

This change ensures DebugComponent returns the correct Bounds.

Reviewed By: aigoncharov

Differential Revision: D40678191

fbshipit-source-id: 1d587efa114a9cd5c0b8162d219e93e3cbad282e
This commit is contained in:
Lorenzo Blasa
2022-10-28 04:58:52 -07:00
committed by Facebook GitHub Bot
parent 587f428cf8
commit 3598fb2cde
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
android/plugins/litho/src/main/java/com/facebook/flipper/plugins/uidebugger/litho/descriptors/DebugComponentDescriptor.kt
View File

@@ -56,7 +56,8 @@ class DebugComponentDescriptor(val register: DescriptorRegister) : NodeDescripto
override fun getData(node: DebugComponent) = mapOf<String, InspectableObject>() override fun getData(node: DebugComponent) = mapOf<String, InspectableObject>()
override fun getBounds(node: DebugComponent): Bounds = Bounds.fromRect(node.bounds) override fun getBounds(node: DebugComponent): Bounds =
Bounds.fromRect(node.boundsInParentDebugComponent)
override fun getTags(node: DebugComponent): Set<String> = setOf(BaseTags.Declarative, LithoTag) override fun getTags(node: DebugComponent): Set<String> = setOf(BaseTags.Declarative, LithoTag)

2
gradle.properties
View File

@@ -17,7 +17,7 @@ POM_DEVELOPER_ID=facebook
POM_DEVELOPER_NAME=facebook POM_DEVELOPER_NAME=facebook
POM_ISSUES_URL=https://github.com/facebook/flipper/issues/ POM_ISSUES_URL=https://github.com/facebook/flipper/issues/
# Shared version numbers # Shared version numbers
LITHO_VERSION=0.43.0 LITHO_VERSION=0.44.0
ANDROIDX_VERSION=1.3.0 ANDROIDX_VERSION=1.3.0
KOTLIN_VERSION=1.6.20 KOTLIN_VERSION=1.6.20
# Gradle internals # Gradle internals