From 3598fb2cdeadf00b44c264933fbd4c7631a859e8 Mon Sep 17 00:00:00 2001 From: Lorenzo Blasa Date: Fri, 28 Oct 2022 04:58:52 -0700 Subject: [PATCH] Use correct bounds for litho debug components Summary: This change is a follow-up on Litho release: https://central.sonatype.dev/artifact/com.facebook.litho/litho-widget-kotlin/0.44.0 This change ensures DebugComponent returns the correct Bounds. Reviewed By: aigoncharov Differential Revision: D40678191 fbshipit-source-id: 1d587efa114a9cd5c0b8162d219e93e3cbad282e --- .../uidebugger/litho/descriptors/DebugComponentDescriptor.kt | 3 ++- gradle.properties | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/android/plugins/litho/src/main/java/com/facebook/flipper/plugins/uidebugger/litho/descriptors/DebugComponentDescriptor.kt b/android/plugins/litho/src/main/java/com/facebook/flipper/plugins/uidebugger/litho/descriptors/DebugComponentDescriptor.kt index cf02d3771..72ec56981 100644 --- a/android/plugins/litho/src/main/java/com/facebook/flipper/plugins/uidebugger/litho/descriptors/DebugComponentDescriptor.kt +++ b/android/plugins/litho/src/main/java/com/facebook/flipper/plugins/uidebugger/litho/descriptors/DebugComponentDescriptor.kt @@ -56,7 +56,8 @@ class DebugComponentDescriptor(val register: DescriptorRegister) : NodeDescripto override fun getData(node: DebugComponent) = mapOf() - override fun getBounds(node: DebugComponent): Bounds = Bounds.fromRect(node.bounds) + override fun getBounds(node: DebugComponent): Bounds = + Bounds.fromRect(node.boundsInParentDebugComponent) override fun getTags(node: DebugComponent): Set = setOf(BaseTags.Declarative, LithoTag) diff --git a/gradle.properties b/gradle.properties index c58b76de2..ada7ae076 100644 --- a/gradle.properties +++ b/gradle.properties @@ -17,7 +17,7 @@ POM_DEVELOPER_ID=facebook POM_DEVELOPER_NAME=facebook POM_ISSUES_URL=https://github.com/facebook/flipper/issues/ # Shared version numbers -LITHO_VERSION=0.43.0 +LITHO_VERSION=0.44.0 ANDROIDX_VERSION=1.3.0 KOTLIN_VERSION=1.6.20 # Gradle internals