jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix screenshot taking and video recording for Windows

Browse Source 
Summary: Turns out Windows really doesn't like colons in filenames. Sigh.

Reviewed By: jknoxville

Differential Revision: D17664236

fbshipit-source-id: 664885308815d862007c8a9a9d1278c426b4e756
This commit is contained in:
Pascal Hartig
2019-09-30 05:23:04 -07:00
committed by Facebook Github Bot
parent 0039d5be4a
commit 31f9d865b2
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/chrome/ScreenCaptureButtons.tsx
View File

@@ -9,8 +9,6 @@ import {Button, ButtonGroup, writeBufferToFile} from 'flipper';
import React, {Component} from 'react'; import React, {Component} from 'react';
import {connect} from 'react-redux'; import {connect} from 'react-redux';
import expandTilde from 'expand-tilde'; import expandTilde from 'expand-tilde';
import os from 'os';
import {spawn} from 'child_process';
import {remote} from 'electron'; import {remote} from 'electron';
import path from 'path'; import path from 'path';
import {reportPlatformFailures} from '../utils/metrics'; import {reportPlatformFailures} from '../utils/metrics';
@@ -50,7 +48,8 @@ async function openFile(path: string | null) {
} }
function getFileName(extension: 'png' | 'mp4'): string { function getFileName(extension: 'png' | 'mp4'): string {
return `Screen Capture ${new Date().toISOString()}.${extension}`; // Windows does not like `:` in its filenames. Yes, I know ...
return `screencap-${new Date().toISOString().replace(/:/g, '')}.${extension}`;
} }
type Props = OwnProps & StateFromProps & DispatchFromProps; type Props = OwnProps & StateFromProps & DispatchFromProps;