From 31f9d865b28815f44e13249578244893dc608cac Mon Sep 17 00:00:00 2001
From: Pascal Hartig <realpassy@fb.com>
Date: Mon, 30 Sep 2019 05:23:04 -0700
Subject: [PATCH] Fix screenshot taking and video recording for Windows

Summary: Turns out Windows really doesn't like colons in filenames. Sigh.

Reviewed By: jknoxville

Differential Revision: D17664236

fbshipit-source-id: 664885308815d862007c8a9a9d1278c426b4e756
---
 src/chrome/ScreenCaptureButtons.tsx | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/chrome/ScreenCaptureButtons.tsx b/src/chrome/ScreenCaptureButtons.tsx
index 731554c89..cf7291b9e 100644
--- a/src/chrome/ScreenCaptureButtons.tsx
+++ b/src/chrome/ScreenCaptureButtons.tsx
@@ -9,8 +9,6 @@ import {Button, ButtonGroup, writeBufferToFile} from 'flipper';
 import React, {Component} from 'react';
 import {connect} from 'react-redux';
 import expandTilde from 'expand-tilde';
-import os from 'os';
-import {spawn} from 'child_process';
 import {remote} from 'electron';
 import path from 'path';
 import {reportPlatformFailures} from '../utils/metrics';
@@ -50,7 +48,8 @@ async function openFile(path: string | null) {
 }
 
 function getFileName(extension: 'png' | 'mp4'): string {
-  return `Screen Capture ${new Date().toISOString()}.${extension}`;
+  // Windows does not like `:` in its filenames. Yes, I know ...
+  return `screencap-${new Date().toISOString().replace(/:/g, '')}.${extension}`;
 }
 
 type Props = OwnProps & StateFromProps & DispatchFromProps;