Fixes an issue with selection by refactoring

Summary: Refactor was going to happen, but it was required at this stage as to fix a selection problem.

Reviewed By: LukeDefeo

Differential Revision: D47831239

fbshipit-source-id: 87ce6250721f6d3df3e826e779409625ddc85660
This commit is contained in:
Lorenzo Blasa
2023-07-27 04:36:24 -07:00
committed by Facebook GitHub Bot
parent 4db7401274
commit 2fd94048fb

View File

@@ -8,14 +8,13 @@
*/ */
import {Layout} from '../ui'; import {Layout} from '../ui';
import React, {createRef, CSSProperties, useState} from 'react'; import React, {CSSProperties, useState} from 'react';
import { import {
createDataSource, createDataSource,
DataFormatter, DataFormatter,
DataInspector, DataInspector,
DataTable, DataTable,
DataTableColumn, DataTableColumn,
DataTableManager,
Tab, Tab,
Tabs, Tabs,
theme, theme,
@@ -129,6 +128,8 @@ function createColumnConfig(): DataTableColumn<ConnectionRecordEntry>[] {
]; ];
} }
const columns = createColumnConfig();
function getRowStyle(entry: ConnectionRecordEntry): CSSProperties | undefined { function getRowStyle(entry: ConnectionRecordEntry): CSSProperties | undefined {
return (logTypes[entry.type]?.style as any) ?? baseRowStyle; return (logTypes[entry.type]?.style as any) ?? baseRowStyle;
} }
@@ -164,14 +165,10 @@ function clearMessages() {
rows.clear(); rows.clear();
} }
export function ConnectivityHub() { const LogView = () => {
const columns = createColumnConfig();
const [selection, setSelection] = useState< const [selection, setSelection] = useState<
ConnectionRecordEntry | undefined ConnectionRecordEntry | undefined
>(); >();
const tableManagerRef = createRef<
undefined | DataTableManager<ConnectionRecordEntry>
>();
const clearButton = ( const clearButton = (
<Button <Button
@@ -184,7 +181,6 @@ export function ConnectivityHub() {
</Button> </Button>
); );
const LogView = () => {
return ( return (
<Layout.Right resizable width={400}> <Layout.Right resizable width={400}>
<DataTable<ConnectionRecordEntry> <DataTable<ConnectionRecordEntry>
@@ -193,7 +189,6 @@ export function ConnectivityHub() {
enableAutoScroll enableAutoScroll
onRowStyle={getRowStyle} onRowStyle={getRowStyle}
onSelect={setSelection} onSelect={setSelection}
tableManagerRef={tableManagerRef}
extraActions={clearButton} extraActions={clearButton}
/> />
<Sidebar selection={selection} /> <Sidebar selection={selection} />
@@ -201,6 +196,7 @@ export function ConnectivityHub() {
); );
}; };
export function ConnectivityHub() {
return ( return (
<Layout.Container grow> <Layout.Container grow>
<Tabs grow> <Tabs grow>