From 2fd94048fb54f2ffbfa7550acb79d71c8eb8bc46 Mon Sep 17 00:00:00 2001
From: Lorenzo Blasa <lblasa@meta.com>
Date: Thu, 27 Jul 2023 04:36:24 -0700
Subject: [PATCH] Fixes an issue with selection by refactoring

Summary: Refactor was going to happen, but it was required at this stage as to fix a selection problem.

Reviewed By: LukeDefeo

Differential Revision: D47831239

fbshipit-source-id: 87ce6250721f6d3df3e826e779409625ddc85660
---
 .../src/chrome/ConnectivityHub.tsx            | 42 +++++++++----------
 1 file changed, 19 insertions(+), 23 deletions(-)

diff --git a/desktop/flipper-ui-core/src/chrome/ConnectivityHub.tsx b/desktop/flipper-ui-core/src/chrome/ConnectivityHub.tsx
index c17a990b4..d6253aa44 100644
--- a/desktop/flipper-ui-core/src/chrome/ConnectivityHub.tsx
+++ b/desktop/flipper-ui-core/src/chrome/ConnectivityHub.tsx
@@ -8,14 +8,13 @@
  */
 
 import {Layout} from '../ui';
-import React, {createRef, CSSProperties, useState} from 'react';
+import React, {CSSProperties, useState} from 'react';
 import {
   createDataSource,
   DataFormatter,
   DataInspector,
   DataTable,
   DataTableColumn,
-  DataTableManager,
   Tab,
   Tabs,
   theme,
@@ -129,6 +128,8 @@ function createColumnConfig(): DataTableColumn<ConnectionRecordEntry>[] {
   ];
 }
 
+const columns = createColumnConfig();
+
 function getRowStyle(entry: ConnectionRecordEntry): CSSProperties | undefined {
   return (logTypes[entry.type]?.style as any) ?? baseRowStyle;
 }
@@ -164,14 +165,10 @@ function clearMessages() {
   rows.clear();
 }
 
-export function ConnectivityHub() {
-  const columns = createColumnConfig();
+const LogView = () => {
   const [selection, setSelection] = useState<
     ConnectionRecordEntry | undefined
   >();
-  const tableManagerRef = createRef<
-    undefined | DataTableManager<ConnectionRecordEntry>
-  >();
 
   const clearButton = (
     <Button
@@ -184,23 +181,22 @@ export function ConnectivityHub() {
     </Button>
   );
 
-  const LogView = () => {
-    return (
-      <Layout.Right resizable width={400}>
-        <DataTable<ConnectionRecordEntry>
-          dataSource={rows}
-          columns={columns}
-          enableAutoScroll
-          onRowStyle={getRowStyle}
-          onSelect={setSelection}
-          tableManagerRef={tableManagerRef}
-          extraActions={clearButton}
-        />
-        <Sidebar selection={selection} />
-      </Layout.Right>
-    );
-  };
+  return (
+    <Layout.Right resizable width={400}>
+      <DataTable<ConnectionRecordEntry>
+        dataSource={rows}
+        columns={columns}
+        enableAutoScroll
+        onRowStyle={getRowStyle}
+        onSelect={setSelection}
+        extraActions={clearButton}
+      />
+      <Sidebar selection={selection} />
+    </Layout.Right>
+  );
+};
 
+export function ConnectivityHub() {
   return (
     <Layout.Container grow>
       <Tabs grow>