jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Back out "[DO NOT LAND until Litho open source version includes rerenderForAccessibility] add litho accessibility rendering to Flipper accessibility mode [2/2]"

Browse Source 
Summary: Original commit changeset: 000a7413fcbe

Reviewed By: passy

Differential Revision: D12821473

fbshipit-source-id: 5fa369cc48f074414b04e4786d5bd634158598a6
This commit is contained in:
Pritesh Nandgaonkar
2018-10-29 06:17:41 -07:00
committed by Facebook Github Bot
parent c938931b4f
commit 2ee2dfacfe
2 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
android/src/main/java/com/facebook/flipper/plugins/litho/GenerateLithoAccessibilityRenderExtensionCommand.java
View File

@@ -75,7 +75,8 @@ public final class GenerateLithoAccessibilityRenderExtensionCommand
while (!lithoViewSearchStack.isEmpty()) { while (!lithoViewSearchStack.isEmpty()) {
ViewGroup v = lithoViewSearchStack.pop(); ViewGroup v = lithoViewSearchStack.pop();
if (v instanceof LithoView) { if (v instanceof LithoView) {
((LithoView) v).rerenderForAccessibility(forceLithoAXRender); // TODO: uncomment once Litho open source updates
// ((LithoView) v).rerenderForAccessibility(forceLithoAXRender);
} else { } else {
for (int i = 0; i < v.getChildCount(); i++) { for (int i = 0; i < v.getChildCount(); i++) {
View child = v.getChildAt(i); View child = v.getChildAt(i);

15
src/plugins/layout/index.js
View File

@@ -545,13 +545,14 @@ export default class Layout extends FlipperPlugin<InspectorState> {
} }
initAX() { initAX() {
this.client // TODO: uncomment once Litho open source updates
.call('shouldShowLithoAccessibilitySettings') // this.client
.then((showLithoAccessibilitySettings: boolean) => { // .call('shouldShowLithoAccessibilitySettings')
this.setState({ // .then((showLithoAccessibilitySettings: boolean) => {
showLithoAccessibilitySettings, // this.setState({
}); // showLithoAccessibilitySettings,
}); // });
// });
performance.mark('InitAXRoot'); performance.mark('InitAXRoot');
this.client.call('getAXRoot').then((element: Element) => { this.client.call('getAXRoot').then((element: Element) => {