From 2ee2dfacfe7b708fa3eb507caeaf191e65e5aadb Mon Sep 17 00:00:00 2001 From: Pritesh Nandgaonkar Date: Mon, 29 Oct 2018 06:17:41 -0700 Subject: [PATCH] Back out "[DO NOT LAND until Litho open source version includes rerenderForAccessibility] add litho accessibility rendering to Flipper accessibility mode [2/2]" Summary: Original commit changeset: 000a7413fcbe Reviewed By: passy Differential Revision: D12821473 fbshipit-source-id: 5fa369cc48f074414b04e4786d5bd634158598a6 --- ...eLithoAccessibilityRenderExtensionCommand.java | 3 ++- src/plugins/layout/index.js | 15 ++++++++------- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/android/src/main/java/com/facebook/flipper/plugins/litho/GenerateLithoAccessibilityRenderExtensionCommand.java b/android/src/main/java/com/facebook/flipper/plugins/litho/GenerateLithoAccessibilityRenderExtensionCommand.java index e511246db..0df3920e3 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/litho/GenerateLithoAccessibilityRenderExtensionCommand.java +++ b/android/src/main/java/com/facebook/flipper/plugins/litho/GenerateLithoAccessibilityRenderExtensionCommand.java @@ -75,7 +75,8 @@ public final class GenerateLithoAccessibilityRenderExtensionCommand while (!lithoViewSearchStack.isEmpty()) { ViewGroup v = lithoViewSearchStack.pop(); if (v instanceof LithoView) { - ((LithoView) v).rerenderForAccessibility(forceLithoAXRender); + // TODO: uncomment once Litho open source updates + // ((LithoView) v).rerenderForAccessibility(forceLithoAXRender); } else { for (int i = 0; i < v.getChildCount(); i++) { View child = v.getChildAt(i); diff --git a/src/plugins/layout/index.js b/src/plugins/layout/index.js index 7fcfa1e13..0ccfd0ade 100644 --- a/src/plugins/layout/index.js +++ b/src/plugins/layout/index.js @@ -545,13 +545,14 @@ export default class Layout extends FlipperPlugin { } initAX() { - this.client - .call('shouldShowLithoAccessibilitySettings') - .then((showLithoAccessibilitySettings: boolean) => { - this.setState({ - showLithoAccessibilitySettings, - }); - }); + // TODO: uncomment once Litho open source updates + // this.client + // .call('shouldShowLithoAccessibilitySettings') + // .then((showLithoAccessibilitySettings: boolean) => { + // this.setState({ + // showLithoAccessibilitySettings, + // }); + // }); performance.mark('InitAXRoot'); this.client.call('getAXRoot').then((element: Element) => {