jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Enable configuring OnDemand for testing

Browse Source 
Summary: While working on D29694696, noticed it is tricky to test against an OnDemand, as the URL format is pretty specific and authentication flow uses an unrelated URL base constant. Introduced `FB_ONDEMAND` env var to make testing easier. If this is a common scenario we could consider making it a setting in the long run.

Reviewed By: timur-valiev

Differential Revision: D29694707

fbshipit-source-id: 747ceb80c95c3bdf0276497c41c9ff5ed9a198f2
This commit is contained in:
Michel Weststrate
2021-07-15 01:51:58 -07:00
committed by Facebook GitHub Bot
parent 7b2afda844
commit 2b6cb0ac3a
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
docs/extending/dev-setup.mdx
View File

@@ -139,6 +139,12 @@ FLIPPER_OPEN_DEV_TOOLS=true
FLIPPER_ENABLED_PLUGINS=flipper-messages,network,inspector FLIPPER_ENABLED_PLUGINS=flipper-messages,network,inspector
``` ```
<FbInternalOnly>
To start Flipper against a specific OnDemand instance, set FB_ONDEMAND flag, e.g: `FB_ONDEMAND=34435.od yarn start`
</FbInternalOnly>
## Guidelines for writing TypeScript ## Guidelines for writing TypeScript
* **Important:** Use `.tsx` file extension for all TypeScript files (instead of `.ts`) * **Important:** Use `.tsx` file extension for all TypeScript files (instead of `.ts`)
* Prefer `type` for React props and state over interfaces * Prefer `type` for React props and state over interfaces