From 2b6cb0ac3af1a208cf301a20422539f6e6497ced Mon Sep 17 00:00:00 2001 From: Michel Weststrate Date: Thu, 15 Jul 2021 01:51:58 -0700 Subject: [PATCH] Enable configuring OnDemand for testing Summary: While working on D29694696, noticed it is tricky to test against an OnDemand, as the URL format is pretty specific and authentication flow uses an unrelated URL base constant. Introduced `FB_ONDEMAND` env var to make testing easier. If this is a common scenario we could consider making it a setting in the long run. Reviewed By: timur-valiev Differential Revision: D29694707 fbshipit-source-id: 747ceb80c95c3bdf0276497c41c9ff5ed9a198f2 --- docs/extending/dev-setup.mdx | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/extending/dev-setup.mdx b/docs/extending/dev-setup.mdx index 9c4153e17..bc57db0cf 100644 --- a/docs/extending/dev-setup.mdx +++ b/docs/extending/dev-setup.mdx @@ -139,6 +139,12 @@ FLIPPER_OPEN_DEV_TOOLS=true FLIPPER_ENABLED_PLUGINS=flipper-messages,network,inspector ``` + + +To start Flipper against a specific OnDemand instance, set FB_ONDEMAND flag, e.g: `FB_ONDEMAND=34435.od yarn start` + + + ## Guidelines for writing TypeScript * **Important:** Use `.tsx` file extension for all TypeScript files (instead of `.ts`) * Prefer `type` for React props and state over interfaces