jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not throw when a plugin removal fails

Browse Source 
Summary:
Symmetry with D48642974.

Changelog: Don't throw in C++ if a plugin gets added/removed multiple times.

Reviewed By: lblasa

Differential Revision: D48643116

fbshipit-source-id: cc6638061b1dee2a6f7deb1fab1093906decc24a
This commit is contained in:
Pascal Hartig
2023-08-25 02:14:22 -07:00
committed by Facebook GitHub Bot
parent 7822099f50
commit 2a6426ebbe
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
xplat/Flipper/FlipperClient.cpp
View File

@@ -92,7 +92,8 @@ void FlipperClient::removePlugin(std::shared_ptr<FlipperPlugin> plugin) {
std::lock_guard<std::mutex> lock(mutex_); std::lock_guard<std::mutex> lock(mutex_);
if (plugins_.find(plugin->identifier()) == plugins_.end()) { if (plugins_.find(plugin->identifier()) == plugins_.end()) {
throw std::out_of_range("plugin " + plugin->identifier() + " not added."); log("plugin " + plugin->identifier() + " not added.");
return;
} }
disconnect(plugin); disconnect(plugin);
plugins_.erase(plugin->identifier()); plugins_.erase(plugin->identifier());