From 2a6426ebbe546e280ba672a237e290bd5da363a2 Mon Sep 17 00:00:00 2001
From: Pascal Hartig <realpassy@meta.com>
Date: Fri, 25 Aug 2023 02:14:22 -0700
Subject: [PATCH] Do not throw when a plugin removal fails

Summary:
Symmetry with D48642974.

Changelog: Don't throw in C++ if a plugin gets added/removed multiple times.

Reviewed By: lblasa

Differential Revision: D48643116

fbshipit-source-id: cc6638061b1dee2a6f7deb1fab1093906decc24a
---
 xplat/Flipper/FlipperClient.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xplat/Flipper/FlipperClient.cpp b/xplat/Flipper/FlipperClient.cpp
index 53537c0e2..a31765746 100644
--- a/xplat/Flipper/FlipperClient.cpp
+++ b/xplat/Flipper/FlipperClient.cpp
@@ -92,7 +92,8 @@ void FlipperClient::removePlugin(std::shared_ptr<FlipperPlugin> plugin) {
 
     std::lock_guard<std::mutex> lock(mutex_);
     if (plugins_.find(plugin->identifier()) == plugins_.end()) {
-      throw std::out_of_range("plugin " + plugin->identifier() + " not added.");
+      log("plugin " + plugin->identifier() + " not added.");
+      return;
     }
     disconnect(plugin);
     plugins_.erase(plugin->identifier());