jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename InspectorSonarPlugin to InspectorFlipperPlugin

Browse Source 
Summary: Per title.

Reviewed By: priteshrnandgaonkar

Differential Revision: D9990824

fbshipit-source-id: f40a769a2f46e5051e09523939ba1034b21e88cb
This commit is contained in:
Pascal Hartig
2018-09-22 09:19:10 -07:00
committed by Facebook Github Bot
parent 4a146eba8b
commit 235916666b
4 changed files with 31 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
android/sample/src/main/java/com/facebook/flipper/sample/FlipperSampleApplication.java
View File

@@ -9,7 +9,7 @@ import com.facebook.soloader.SoLoader;
import com.facebook.flipper.android.AndroidFlipperClient; import com.facebook.flipper.android.AndroidFlipperClient;
import com.facebook.flipper.core.FlipperClient; import com.facebook.flipper.core.FlipperClient;
import com.facebook.flipper.plugins.inspector.DescriptorMapping; import com.facebook.flipper.plugins.inspector.DescriptorMapping;
import com.facebook.flipper.plugins.inspector.InspectorSonarPlugin; import com.facebook.flipper.plugins.inspector.InspectorFlipperPlugin;
import com.facebook.flipper.plugins.leakcanary.LeakCanarySonarPlugin; import com.facebook.flipper.plugins.leakcanary.LeakCanarySonarPlugin;
import com.facebook.flipper.plugins.litho.LithoSonarDescriptors; import com.facebook.flipper.plugins.litho.LithoSonarDescriptors;
import com.facebook.flipper.plugins.network.NetworkSonarPlugin; import com.facebook.flipper.plugins.network.NetworkSonarPlugin;
@@ -44,7 +44,7 @@ public class FlipperSampleApplication extends Application {
// for this demo application we can safely assume that you always want to debug. // for this demo application we can safely assume that you always want to debug.
ComponentsConfiguration.isDebugModeEnabled = true; ComponentsConfiguration.isDebugModeEnabled = true;
LithoSonarDescriptors.add(descriptorMapping); LithoSonarDescriptors.add(descriptorMapping);
client.addPlugin(new InspectorSonarPlugin(this, descriptorMapping)); client.addPlugin(new InspectorFlipperPlugin(this, descriptorMapping));
client.addPlugin(networkPlugin); client.addPlugin(networkPlugin);
client.addPlugin(new SharedPreferencesSonarPlugin(this, "sample")); client.addPlugin(new SharedPreferencesSonarPlugin(this, "sample"));
client.addPlugin(new LeakCanarySonarPlugin()); client.addPlugin(new LeakCanarySonarPlugin());

12
android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorSonarPlugin.java → android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java
View File

@@ -35,7 +35,7 @@ import java.util.List;
import java.util.Stack; import java.util.Stack;
import javax.annotation.Nullable; import javax.annotation.Nullable;
public class InspectorSonarPlugin implements FlipperPlugin { public class InspectorFlipperPlugin implements FlipperPlugin {
private ApplicationWrapper mApplication; private ApplicationWrapper mApplication;
private DescriptorMapping mDescriptorMapping; private DescriptorMapping mDescriptorMapping;
@@ -61,11 +61,11 @@ public class InspectorSonarPlugin implements FlipperPlugin {
return (Application) context; return (Application) context;
} }
public InspectorSonarPlugin(Context context, DescriptorMapping descriptorMapping) { public InspectorFlipperPlugin(Context context, DescriptorMapping descriptorMapping) {
this(getAppContextFromContext(context), descriptorMapping, new NullScriptingEnvironment()); this(getAppContextFromContext(context), descriptorMapping, new NullScriptingEnvironment());
} }
public InspectorSonarPlugin( public InspectorFlipperPlugin(
Context context, Context context,
DescriptorMapping descriptorMapping, DescriptorMapping descriptorMapping,
ScriptingEnvironment scriptingEnvironment) { ScriptingEnvironment scriptingEnvironment) {
@@ -76,7 +76,7 @@ public class InspectorSonarPlugin implements FlipperPlugin {
null); null);
} }
public InspectorSonarPlugin( public InspectorFlipperPlugin(
Context context, Context context,
DescriptorMapping descriptorMapping, DescriptorMapping descriptorMapping,
@Nullable List<ExtensionCommand> extensions) { @Nullable List<ExtensionCommand> extensions) {
@@ -87,7 +87,7 @@ public class InspectorSonarPlugin implements FlipperPlugin {
extensions); extensions);
} }
public InspectorSonarPlugin( public InspectorFlipperPlugin(
Context context, Context context,
DescriptorMapping descriptorMapping, DescriptorMapping descriptorMapping,
ScriptingEnvironment scriptingEnvironment, ScriptingEnvironment scriptingEnvironment,
@@ -101,7 +101,7 @@ public class InspectorSonarPlugin implements FlipperPlugin {
} }
// Package visible for testing // Package visible for testing
InspectorSonarPlugin( InspectorFlipperPlugin(
ApplicationWrapper wrapper, ApplicationWrapper wrapper,
DescriptorMapping descriptorMapping, DescriptorMapping descriptorMapping,
ScriptingEnvironment scriptingEnvironment, ScriptingEnvironment scriptingEnvironment,

4
android/src/main/java/com/facebook/flipper/plugins/litho/GenerateLithoAccessibilityRenderExtensionCommand.java
View File

@@ -11,12 +11,12 @@ import com.facebook.flipper.core.FlipperReceiver;
import com.facebook.flipper.core.FlipperResponder; import com.facebook.flipper.core.FlipperResponder;
import com.facebook.flipper.plugins.common.MainThreadFlipperReceiver; import com.facebook.flipper.plugins.common.MainThreadFlipperReceiver;
import com.facebook.flipper.plugins.inspector.ApplicationWrapper; import com.facebook.flipper.plugins.inspector.ApplicationWrapper;
import com.facebook.flipper.plugins.inspector.InspectorSonarPlugin; import com.facebook.flipper.plugins.inspector.InspectorFlipperPlugin;
import com.facebook.flipper.plugins.inspector.ObjectTracker; import com.facebook.flipper.plugins.inspector.ObjectTracker;
import java.util.Stack; import java.util.Stack;
public final class GenerateLithoAccessibilityRenderExtensionCommand implements InspectorSonarPlugin.ExtensionCommand { public final class GenerateLithoAccessibilityRenderExtensionCommand implements InspectorFlipperPlugin.ExtensionCommand {
@Override @Override
public String command() { public String command() {

42
android/src/test/java/com/facebook/sonar/plugins/inspector/InspectorSonarPluginTest.java
View File

@@ -22,7 +22,7 @@ import com.facebook.flipper.core.FlipperDynamic;
import com.facebook.flipper.core.FlipperObject; import com.facebook.flipper.core.FlipperObject;
import com.facebook.flipper.plugins.console.iface.NullScriptingEnvironment; import com.facebook.flipper.plugins.console.iface.NullScriptingEnvironment;
import com.facebook.flipper.plugins.console.iface.ScriptingEnvironment; import com.facebook.flipper.plugins.console.iface.ScriptingEnvironment;
import com.facebook.flipper.plugins.inspector.InspectorSonarPlugin.TouchOverlayView; import com.facebook.flipper.plugins.inspector.InspectorFlipperPlugin.TouchOverlayView;
import com.facebook.flipper.plugins.inspector.descriptors.ApplicationDescriptor; import com.facebook.flipper.plugins.inspector.descriptors.ApplicationDescriptor;
import com.facebook.flipper.testing.FlipperConnectionMock; import com.facebook.flipper.testing.FlipperConnectionMock;
import com.facebook.flipper.testing.FlipperResponderMock; import com.facebook.flipper.testing.FlipperResponderMock;
@@ -61,8 +61,8 @@ public class InspectorSonarPluginTest {
@Test @Test
public void testOnConnect() throws Exception { public void testOnConnect() throws Exception {
final InspectorSonarPlugin plugin = final InspectorFlipperPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final FlipperConnection connection = new FlipperConnectionMock(); final FlipperConnection connection = new FlipperConnectionMock();
plugin.onConnect(connection); plugin.onConnect(connection);
@@ -71,8 +71,8 @@ public class InspectorSonarPluginTest {
@Test @Test
public void testOnDisconnect() throws Exception { public void testOnDisconnect() throws Exception {
final InspectorSonarPlugin plugin = final InspectorFlipperPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final FlipperConnection connection = new FlipperConnectionMock(); final FlipperConnection connection = new FlipperConnectionMock();
plugin.onConnect(connection); plugin.onConnect(connection);
@@ -82,8 +82,8 @@ public class InspectorSonarPluginTest {
@Test @Test
public void testGetRoot() throws Exception { public void testGetRoot() throws Exception {
final InspectorSonarPlugin plugin = final InspectorFlipperPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final FlipperResponderMock responder = new FlipperResponderMock(); final FlipperResponderMock responder = new FlipperResponderMock();
final FlipperConnectionMock connection = new FlipperConnectionMock(); final FlipperConnectionMock connection = new FlipperConnectionMock();
plugin.onConnect(connection); plugin.onConnect(connection);
@@ -109,8 +109,8 @@ public class InspectorSonarPluginTest {
@Test @Test
public void testGetNodes() throws Exception { public void testGetNodes() throws Exception {
final InspectorSonarPlugin plugin = final InspectorFlipperPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final FlipperResponderMock responder = new FlipperResponderMock(); final FlipperResponderMock responder = new FlipperResponderMock();
final FlipperConnectionMock connection = new FlipperConnectionMock(); final FlipperConnectionMock connection = new FlipperConnectionMock();
plugin.onConnect(connection); plugin.onConnect(connection);
@@ -146,8 +146,8 @@ public class InspectorSonarPluginTest {
@Test @Test
public void testGetNodesThatDontExist() throws Exception { public void testGetNodesThatDontExist() throws Exception {
final InspectorSonarPlugin plugin = final InspectorFlipperPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final FlipperResponderMock responder = new FlipperResponderMock(); final FlipperResponderMock responder = new FlipperResponderMock();
final FlipperConnectionMock connection = new FlipperConnectionMock(); final FlipperConnectionMock connection = new FlipperConnectionMock();
plugin.onConnect(connection); plugin.onConnect(connection);
@@ -172,8 +172,8 @@ public class InspectorSonarPluginTest {
@Test @Test
public void testSetData() throws Exception { public void testSetData() throws Exception {
final InspectorSonarPlugin plugin = final InspectorFlipperPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final FlipperConnectionMock connection = new FlipperConnectionMock(); final FlipperConnectionMock connection = new FlipperConnectionMock();
final FlipperResponderMock responder = new FlipperResponderMock(); final FlipperResponderMock responder = new FlipperResponderMock();
plugin.onConnect(connection); plugin.onConnect(connection);
@@ -208,8 +208,8 @@ public class InspectorSonarPluginTest {
@Test @Test
public void testSetHighlighted() throws Exception { public void testSetHighlighted() throws Exception {
final InspectorSonarPlugin plugin = final InspectorFlipperPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final FlipperConnectionMock connection = new FlipperConnectionMock(); final FlipperConnectionMock connection = new FlipperConnectionMock();
final FlipperResponderMock responder = new FlipperResponderMock(); final FlipperResponderMock responder = new FlipperResponderMock();
plugin.onConnect(connection); plugin.onConnect(connection);
@@ -237,8 +237,8 @@ public class InspectorSonarPluginTest {
@Test @Test
public void testHitTest() throws Exception { public void testHitTest() throws Exception {
final InspectorSonarPlugin plugin = final InspectorFlipperPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final FlipperConnectionMock connection = new FlipperConnectionMock(); final FlipperConnectionMock connection = new FlipperConnectionMock();
plugin.onConnect(connection); plugin.onConnect(connection);
@@ -274,8 +274,8 @@ public class InspectorSonarPluginTest {
@Test @Test
public void testSetSearchActive() throws Exception { public void testSetSearchActive() throws Exception {
final InspectorSonarPlugin plugin = final InspectorFlipperPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final FlipperConnectionMock connection = new FlipperConnectionMock(); final FlipperConnectionMock connection = new FlipperConnectionMock();
final FlipperResponderMock responder = new FlipperResponderMock(); final FlipperResponderMock responder = new FlipperResponderMock();
plugin.onConnect(connection); plugin.onConnect(connection);
@@ -296,8 +296,8 @@ public class InspectorSonarPluginTest {
@Test(expected = AssertionError.class) @Test(expected = AssertionError.class)
public void testNullChildThrows() throws Exception { public void testNullChildThrows() throws Exception {
final InspectorSonarPlugin plugin = final InspectorFlipperPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final FlipperResponderMock responder = new FlipperResponderMock(); final FlipperResponderMock responder = new FlipperResponderMock();
final FlipperConnectionMock connection = new FlipperConnectionMock(); final FlipperConnectionMock connection = new FlipperConnectionMock();
plugin.onConnect(connection); plugin.onConnect(connection);