From 235916666b25352a813a236e1f35c659c63b0b67 Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Sat, 22 Sep 2018 09:19:10 -0700 Subject: [PATCH] Rename InspectorSonarPlugin to InspectorFlipperPlugin Summary: Per title. Reviewed By: priteshrnandgaonkar Differential Revision: D9990824 fbshipit-source-id: f40a769a2f46e5051e09523939ba1034b21e88cb --- .../sample/FlipperSampleApplication.java | 4 +- ...lugin.java => InspectorFlipperPlugin.java} | 12 +++--- ...hoAccessibilityRenderExtensionCommand.java | 4 +- .../inspector/InspectorSonarPluginTest.java | 42 +++++++++---------- 4 files changed, 31 insertions(+), 31 deletions(-) rename android/src/main/java/com/facebook/flipper/plugins/inspector/{InspectorSonarPlugin.java => InspectorFlipperPlugin.java} (98%) diff --git a/android/sample/src/main/java/com/facebook/flipper/sample/FlipperSampleApplication.java b/android/sample/src/main/java/com/facebook/flipper/sample/FlipperSampleApplication.java index a154a1cdd..28a6132cb 100644 --- a/android/sample/src/main/java/com/facebook/flipper/sample/FlipperSampleApplication.java +++ b/android/sample/src/main/java/com/facebook/flipper/sample/FlipperSampleApplication.java @@ -9,7 +9,7 @@ import com.facebook.soloader.SoLoader; import com.facebook.flipper.android.AndroidFlipperClient; import com.facebook.flipper.core.FlipperClient; import com.facebook.flipper.plugins.inspector.DescriptorMapping; -import com.facebook.flipper.plugins.inspector.InspectorSonarPlugin; +import com.facebook.flipper.plugins.inspector.InspectorFlipperPlugin; import com.facebook.flipper.plugins.leakcanary.LeakCanarySonarPlugin; import com.facebook.flipper.plugins.litho.LithoSonarDescriptors; import com.facebook.flipper.plugins.network.NetworkSonarPlugin; @@ -44,7 +44,7 @@ public class FlipperSampleApplication extends Application { // for this demo application we can safely assume that you always want to debug. ComponentsConfiguration.isDebugModeEnabled = true; LithoSonarDescriptors.add(descriptorMapping); - client.addPlugin(new InspectorSonarPlugin(this, descriptorMapping)); + client.addPlugin(new InspectorFlipperPlugin(this, descriptorMapping)); client.addPlugin(networkPlugin); client.addPlugin(new SharedPreferencesSonarPlugin(this, "sample")); client.addPlugin(new LeakCanarySonarPlugin()); diff --git a/android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorSonarPlugin.java b/android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java similarity index 98% rename from android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorSonarPlugin.java rename to android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java index db6b4cc8f..061f90a5b 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorSonarPlugin.java +++ b/android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java @@ -35,7 +35,7 @@ import java.util.List; import java.util.Stack; import javax.annotation.Nullable; -public class InspectorSonarPlugin implements FlipperPlugin { +public class InspectorFlipperPlugin implements FlipperPlugin { private ApplicationWrapper mApplication; private DescriptorMapping mDescriptorMapping; @@ -61,11 +61,11 @@ public class InspectorSonarPlugin implements FlipperPlugin { return (Application) context; } - public InspectorSonarPlugin(Context context, DescriptorMapping descriptorMapping) { + public InspectorFlipperPlugin(Context context, DescriptorMapping descriptorMapping) { this(getAppContextFromContext(context), descriptorMapping, new NullScriptingEnvironment()); } - public InspectorSonarPlugin( + public InspectorFlipperPlugin( Context context, DescriptorMapping descriptorMapping, ScriptingEnvironment scriptingEnvironment) { @@ -76,7 +76,7 @@ public class InspectorSonarPlugin implements FlipperPlugin { null); } - public InspectorSonarPlugin( + public InspectorFlipperPlugin( Context context, DescriptorMapping descriptorMapping, @Nullable List extensions) { @@ -87,7 +87,7 @@ public class InspectorSonarPlugin implements FlipperPlugin { extensions); } - public InspectorSonarPlugin( + public InspectorFlipperPlugin( Context context, DescriptorMapping descriptorMapping, ScriptingEnvironment scriptingEnvironment, @@ -101,7 +101,7 @@ public class InspectorSonarPlugin implements FlipperPlugin { } // Package visible for testing - InspectorSonarPlugin( + InspectorFlipperPlugin( ApplicationWrapper wrapper, DescriptorMapping descriptorMapping, ScriptingEnvironment scriptingEnvironment, diff --git a/android/src/main/java/com/facebook/flipper/plugins/litho/GenerateLithoAccessibilityRenderExtensionCommand.java b/android/src/main/java/com/facebook/flipper/plugins/litho/GenerateLithoAccessibilityRenderExtensionCommand.java index 14cf5bbda..d10ad138e 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/litho/GenerateLithoAccessibilityRenderExtensionCommand.java +++ b/android/src/main/java/com/facebook/flipper/plugins/litho/GenerateLithoAccessibilityRenderExtensionCommand.java @@ -11,12 +11,12 @@ import com.facebook.flipper.core.FlipperReceiver; import com.facebook.flipper.core.FlipperResponder; import com.facebook.flipper.plugins.common.MainThreadFlipperReceiver; import com.facebook.flipper.plugins.inspector.ApplicationWrapper; -import com.facebook.flipper.plugins.inspector.InspectorSonarPlugin; +import com.facebook.flipper.plugins.inspector.InspectorFlipperPlugin; import com.facebook.flipper.plugins.inspector.ObjectTracker; import java.util.Stack; -public final class GenerateLithoAccessibilityRenderExtensionCommand implements InspectorSonarPlugin.ExtensionCommand { +public final class GenerateLithoAccessibilityRenderExtensionCommand implements InspectorFlipperPlugin.ExtensionCommand { @Override public String command() { diff --git a/android/src/test/java/com/facebook/sonar/plugins/inspector/InspectorSonarPluginTest.java b/android/src/test/java/com/facebook/sonar/plugins/inspector/InspectorSonarPluginTest.java index 3372be8b7..810bb87e9 100644 --- a/android/src/test/java/com/facebook/sonar/plugins/inspector/InspectorSonarPluginTest.java +++ b/android/src/test/java/com/facebook/sonar/plugins/inspector/InspectorSonarPluginTest.java @@ -22,7 +22,7 @@ import com.facebook.flipper.core.FlipperDynamic; import com.facebook.flipper.core.FlipperObject; import com.facebook.flipper.plugins.console.iface.NullScriptingEnvironment; import com.facebook.flipper.plugins.console.iface.ScriptingEnvironment; -import com.facebook.flipper.plugins.inspector.InspectorSonarPlugin.TouchOverlayView; +import com.facebook.flipper.plugins.inspector.InspectorFlipperPlugin.TouchOverlayView; import com.facebook.flipper.plugins.inspector.descriptors.ApplicationDescriptor; import com.facebook.flipper.testing.FlipperConnectionMock; import com.facebook.flipper.testing.FlipperResponderMock; @@ -61,8 +61,8 @@ public class InspectorSonarPluginTest { @Test public void testOnConnect() throws Exception { - final InspectorSonarPlugin plugin = - new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); + final InspectorFlipperPlugin plugin = + new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); final FlipperConnection connection = new FlipperConnectionMock(); plugin.onConnect(connection); @@ -71,8 +71,8 @@ public class InspectorSonarPluginTest { @Test public void testOnDisconnect() throws Exception { - final InspectorSonarPlugin plugin = - new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); + final InspectorFlipperPlugin plugin = + new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); final FlipperConnection connection = new FlipperConnectionMock(); plugin.onConnect(connection); @@ -82,8 +82,8 @@ public class InspectorSonarPluginTest { @Test public void testGetRoot() throws Exception { - final InspectorSonarPlugin plugin = - new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); + final InspectorFlipperPlugin plugin = + new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); final FlipperResponderMock responder = new FlipperResponderMock(); final FlipperConnectionMock connection = new FlipperConnectionMock(); plugin.onConnect(connection); @@ -109,8 +109,8 @@ public class InspectorSonarPluginTest { @Test public void testGetNodes() throws Exception { - final InspectorSonarPlugin plugin = - new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); + final InspectorFlipperPlugin plugin = + new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); final FlipperResponderMock responder = new FlipperResponderMock(); final FlipperConnectionMock connection = new FlipperConnectionMock(); plugin.onConnect(connection); @@ -146,8 +146,8 @@ public class InspectorSonarPluginTest { @Test public void testGetNodesThatDontExist() throws Exception { - final InspectorSonarPlugin plugin = - new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); + final InspectorFlipperPlugin plugin = + new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); final FlipperResponderMock responder = new FlipperResponderMock(); final FlipperConnectionMock connection = new FlipperConnectionMock(); plugin.onConnect(connection); @@ -172,8 +172,8 @@ public class InspectorSonarPluginTest { @Test public void testSetData() throws Exception { - final InspectorSonarPlugin plugin = - new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); + final InspectorFlipperPlugin plugin = + new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); final FlipperConnectionMock connection = new FlipperConnectionMock(); final FlipperResponderMock responder = new FlipperResponderMock(); plugin.onConnect(connection); @@ -208,8 +208,8 @@ public class InspectorSonarPluginTest { @Test public void testSetHighlighted() throws Exception { - final InspectorSonarPlugin plugin = - new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); + final InspectorFlipperPlugin plugin = + new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); final FlipperConnectionMock connection = new FlipperConnectionMock(); final FlipperResponderMock responder = new FlipperResponderMock(); plugin.onConnect(connection); @@ -237,8 +237,8 @@ public class InspectorSonarPluginTest { @Test public void testHitTest() throws Exception { - final InspectorSonarPlugin plugin = - new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); + final InspectorFlipperPlugin plugin = + new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); final FlipperConnectionMock connection = new FlipperConnectionMock(); plugin.onConnect(connection); @@ -274,8 +274,8 @@ public class InspectorSonarPluginTest { @Test public void testSetSearchActive() throws Exception { - final InspectorSonarPlugin plugin = - new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); + final InspectorFlipperPlugin plugin = + new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); final FlipperConnectionMock connection = new FlipperConnectionMock(); final FlipperResponderMock responder = new FlipperResponderMock(); plugin.onConnect(connection); @@ -296,8 +296,8 @@ public class InspectorSonarPluginTest { @Test(expected = AssertionError.class) public void testNullChildThrows() throws Exception { - final InspectorSonarPlugin plugin = - new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); + final InspectorFlipperPlugin plugin = + new InspectorFlipperPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null); final FlipperResponderMock responder = new FlipperResponderMock(); final FlipperConnectionMock connection = new FlipperConnectionMock(); plugin.onConnect(connection);