jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

update accessibility hierarchy to show class names

Browse Source 
Summary: Show the simple name instead of the node info class since this is taken into account for the attributes.

Reviewed By: jknoxville

Differential Revision: D18574219

fbshipit-source-id: 4b134e8be18c313e08df423dcdbe286d96c80b56
This commit is contained in:
Sara Valderrama
2019-11-19 10:01:49 -08:00
committed by Facebook Github Bot
parent 352d9c82cb
commit 19df98e525
1 changed files with 1 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewDescriptor.java
View File

@@ -27,7 +27,6 @@ import android.widget.FrameLayout;
import android.widget.LinearLayout;
import androidx.core.view.MarginLayoutParamsCompat;
import androidx.core.view.ViewCompat;
import androidx.core.view.accessibility.AccessibilityNodeInfoCompat;
import com.facebook.flipper.core.ErrorReportingRunnable;
import com.facebook.flipper.core.FlipperDynamic;
import com.facebook.flipper.core.FlipperObject;
@@ -40,7 +39,6 @@ import com.facebook.flipper.plugins.inspector.descriptors.utils.AccessibilityEva
import com.facebook.flipper.plugins.inspector.descriptors.utils.AccessibilityRoleUtil;
import com.facebook.flipper.plugins.inspector.descriptors.utils.AccessibilityUtil;
import com.facebook.flipper.plugins.inspector.descriptors.utils.EnumMapping;
import com.facebook.flipper.plugins.inspector.descriptors.utils.ViewAccessibilityHelper;
import com.facebook.stetho.common.android.ResourcesUtil;
import java.lang.reflect.Field;
import java.util.ArrayList;
@@ -88,21 +86,7 @@ public class ViewDescriptor extends NodeDescriptor<View> {
@Override
public String getAXName(View node) throws Exception {
AccessibilityNodeInfoCompat nodeInfo = ViewAccessibilityHelper.createNodeInfoFromView(node);
if (nodeInfo != null) {
CharSequence name = nodeInfo.getClassName();
nodeInfo.recycle();
if (name != null && name != "") {
return name.toString();
}
}
// A node may have no name if a custom role description was set, but no
// role, or if the AccessibilityNodeInfo could not be generated. If this is
// the case name just give this node a generic name.
return "AccessibilityNode";
return node.getClass().getSimpleName();
}
@Override