From 19df98e525a1849b591c20194df37a441ce2d277 Mon Sep 17 00:00:00 2001 From: Sara Valderrama Date: Tue, 19 Nov 2019 10:01:49 -0800 Subject: [PATCH] update accessibility hierarchy to show class names Summary: Show the simple name instead of the node info class since this is taken into account for the attributes. Reviewed By: jknoxville Differential Revision: D18574219 fbshipit-source-id: 4b134e8be18c313e08df423dcdbe286d96c80b56 --- .../inspector/descriptors/ViewDescriptor.java | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewDescriptor.java b/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewDescriptor.java index 4401b2d3a..ef8d8fcd0 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewDescriptor.java +++ b/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewDescriptor.java @@ -27,7 +27,6 @@ import android.widget.FrameLayout; import android.widget.LinearLayout; import androidx.core.view.MarginLayoutParamsCompat; import androidx.core.view.ViewCompat; -import androidx.core.view.accessibility.AccessibilityNodeInfoCompat; import com.facebook.flipper.core.ErrorReportingRunnable; import com.facebook.flipper.core.FlipperDynamic; import com.facebook.flipper.core.FlipperObject; @@ -40,7 +39,6 @@ import com.facebook.flipper.plugins.inspector.descriptors.utils.AccessibilityEva import com.facebook.flipper.plugins.inspector.descriptors.utils.AccessibilityRoleUtil; import com.facebook.flipper.plugins.inspector.descriptors.utils.AccessibilityUtil; import com.facebook.flipper.plugins.inspector.descriptors.utils.EnumMapping; -import com.facebook.flipper.plugins.inspector.descriptors.utils.ViewAccessibilityHelper; import com.facebook.stetho.common.android.ResourcesUtil; import java.lang.reflect.Field; import java.util.ArrayList; @@ -88,21 +86,7 @@ public class ViewDescriptor extends NodeDescriptor { @Override public String getAXName(View node) throws Exception { - AccessibilityNodeInfoCompat nodeInfo = ViewAccessibilityHelper.createNodeInfoFromView(node); - if (nodeInfo != null) { - - CharSequence name = nodeInfo.getClassName(); - nodeInfo.recycle(); - - if (name != null && name != "") { - return name.toString(); - } - } - - // A node may have no name if a custom role description was set, but no - // role, or if the AccessibilityNodeInfo could not be generated. If this is - // the case name just give this node a generic name. - return "AccessibilityNode"; + return node.getClass().getSimpleName(); } @Override