jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename startWebServerDev to startDevServer

Browse Source 
Summary:
Rename 'startWebServerDev' to just 'startDevServer'.

It isn't really starting a web server though, more like installing routings and middleware to the existing created server.

Reviewed By: passy

Differential Revision: D36310765

fbshipit-source-id: 0af772012525fd7ad19e2aa6fa73cb3e7dcf2bef
This commit is contained in:
Lorenzo Blasa
2022-05-11 06:56:20 -07:00
committed by Facebook GitHub Bot
parent ec667bc26d
commit 1818b87166
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
desktop/flipper-server/src/index.tsx
View File

@@ -13,7 +13,7 @@ import path from 'path';
import {startFlipperServer} from './startFlipperServer'; import {startFlipperServer} from './startFlipperServer';
import {startBaseServer} from './startBaseServer'; import {startBaseServer} from './startBaseServer';
import {startSocketServer} from './startSocketServer'; import {startSocketServer} from './startSocketServer';
import {startWebServerDev} from './startWebServerDev'; import {startDevServer} from './startDevServer';
import yargs from 'yargs'; import yargs from 'yargs';
import open from 'open'; import open from 'open';
@@ -82,6 +82,7 @@ async function start() {
staticDir, staticDir,
entry: 'index.web.dev.html', entry: 'index.web.dev.html',
}); });
const flipperServer = await startFlipperServer( const flipperServer = await startFlipperServer(
rootDir, rootDir,
staticDir, staticDir,
@@ -99,7 +100,7 @@ async function start() {
await flipperServer.connect(); await flipperServer.connect();
if (argv.bundler) { if (argv.bundler) {
await startWebServerDev(app, server, socket, rootDir); await startDevServer(app, server, socket, rootDir);
} }
startSocketServer(flipperServer, socket, companionEnv); startSocketServer(flipperServer, socket, companionEnv);
} }

2
desktop/flipper-server/src/startWebServerDev.tsx → desktop/flipper-server/src/startDevServer.tsx
View File

@@ -48,7 +48,7 @@ export async function getPluginSourceFolders(): Promise<string[]> {
return pFilter(pluginFolders, (p) => fs.pathExists(p)); return pFilter(pluginFolders, (p) => fs.pathExists(p));
} }
export async function startWebServerDev( export async function startDevServer(
app: Express, app: Express,
server: http.Server, server: http.Server,
socket: WebSocketServer, socket: WebSocketServer,