From 1818b87166e839b805ab77631609ffe0a22972b0 Mon Sep 17 00:00:00 2001 From: Lorenzo Blasa Date: Wed, 11 May 2022 06:56:20 -0700 Subject: [PATCH] Rename startWebServerDev to startDevServer Summary: Rename 'startWebServerDev' to just 'startDevServer'. It isn't really starting a web server though, more like installing routings and middleware to the existing created server. Reviewed By: passy Differential Revision: D36310765 fbshipit-source-id: 0af772012525fd7ad19e2aa6fa73cb3e7dcf2bef --- desktop/flipper-server/src/index.tsx | 5 +++-- .../src/{startWebServerDev.tsx => startDevServer.tsx} | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) rename desktop/flipper-server/src/{startWebServerDev.tsx => startDevServer.tsx} (99%) diff --git a/desktop/flipper-server/src/index.tsx b/desktop/flipper-server/src/index.tsx index b4739045b..1eccc24d2 100644 --- a/desktop/flipper-server/src/index.tsx +++ b/desktop/flipper-server/src/index.tsx @@ -13,7 +13,7 @@ import path from 'path'; import {startFlipperServer} from './startFlipperServer'; import {startBaseServer} from './startBaseServer'; import {startSocketServer} from './startSocketServer'; -import {startWebServerDev} from './startWebServerDev'; +import {startDevServer} from './startDevServer'; import yargs from 'yargs'; import open from 'open'; @@ -82,6 +82,7 @@ async function start() { staticDir, entry: 'index.web.dev.html', }); + const flipperServer = await startFlipperServer( rootDir, staticDir, @@ -99,7 +100,7 @@ async function start() { await flipperServer.connect(); if (argv.bundler) { - await startWebServerDev(app, server, socket, rootDir); + await startDevServer(app, server, socket, rootDir); } startSocketServer(flipperServer, socket, companionEnv); } diff --git a/desktop/flipper-server/src/startWebServerDev.tsx b/desktop/flipper-server/src/startDevServer.tsx similarity index 99% rename from desktop/flipper-server/src/startWebServerDev.tsx rename to desktop/flipper-server/src/startDevServer.tsx index c98faa76c..1b50fb1db 100644 --- a/desktop/flipper-server/src/startWebServerDev.tsx +++ b/desktop/flipper-server/src/startDevServer.tsx @@ -48,7 +48,7 @@ export async function getPluginSourceFolders(): Promise { return pFilter(pluginFolders, (p) => fs.pathExists(p)); } -export async function startWebServerDev( +export async function startDevServer( app: Express, server: http.Server, socket: WebSocketServer,