jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove Flipper logs export menu

Browse Source 
Summary:
Design doc: https://docs.google.com/document/d/1HLCFl46RfqG0o1mSt8SWrwf_HMfOCRg_oENioc1rkvQ/edit#

We have a universal export now. Why would we ask for logs only?

Reviewed By: passy

Differential Revision: D40553127

fbshipit-source-id: 674482e39746e789d70bf800daa5f021d83bb093
This commit is contained in:
Andrey Goncharov
2022-10-25 05:31:48 -07:00
committed by Facebook GitHub Bot
parent 2289d6c0e2
commit 14bdc87b11
2 changed files with 0 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
desktop/flipper-ui-core/src/sandy-chrome/LeftRail.tsx
View File

@@ -72,7 +72,6 @@ import {
showOpenDialog, showOpenDialog,
startFileExport, startFileExport,
startLinkExport, startLinkExport,
startFlipperLogsExport,
ExportEverythingEverywhereAllAtOnceStatus, ExportEverythingEverywhereAllAtOnceStatus,
} from '../utils/exportData'; } from '../utils/exportData';
import {openDeeplinkDialog} from '../deeplink'; import {openDeeplinkDialog} from '../deeplink';
@@ -238,11 +237,6 @@ function ExtrasMenu() {
() => startFileExport(store.dispatch), () => startFileExport(store.dispatch),
[store.dispatch], [store.dispatch],
); );
const startLogsExportTracked = useTrackedCallback(
'Logs export',
startFlipperLogsExport,
[],
);
const startLinkExportTracked = useTrackedCallback( const startLinkExportTracked = useTrackedCallback(
'Link export', 'Link export',
() => startLinkExport(store.dispatch), () => startLinkExport(store.dispatch),
@@ -278,11 +272,6 @@ function ExtrasMenu() {
key="extras" key="extras"
title={<LeftRailButton icon={<SettingOutlined />} small />} title={<LeftRailButton icon={<SettingOutlined />} small />}
className={submenu}> className={submenu}>
{canFileExport() ? (
<Menu.Item key="exportLogs" onClick={startLogsExportTracked}>
Export Flipper logs
</Menu.Item>
) : null}
{canOpenDialog() ? ( {canOpenDialog() ? (
<Menu.Item key="importFlipperFile" onClick={startImportTracked}> <Menu.Item key="importFlipperFile" onClick={startImportTracked}>
Import Flipper file Import Flipper file

7
desktop/flipper-ui-core/src/utils/exportData.tsx
View File

@@ -613,13 +613,6 @@ export function canFileExport() {
return !!getRenderHostInstance().showSaveDialog; return !!getRenderHostInstance().showSaveDialog;
} }
export async function startFlipperLogsExport() {
const serializedLogs = exportLogs
.map((item) => JSON.stringify(item))
.join('\n');
await getRenderHostInstance().exportFile?.(serializedLogs);
}
async function startDeviceFlipperFolderExport() { async function startDeviceFlipperFolderExport() {
return await getRenderHostInstance().flipperServer.exec( return await getRenderHostInstance().flipperServer.exec(
{timeout: 3 * 60 * 1000}, {timeout: 3 * 60 * 1000},