From 14bdc87b11099eaec6d5cf8cbfd2f1975b07eac4 Mon Sep 17 00:00:00 2001 From: Andrey Goncharov Date: Tue, 25 Oct 2022 05:31:48 -0700 Subject: [PATCH] Remove Flipper logs export menu Summary: Design doc: https://docs.google.com/document/d/1HLCFl46RfqG0o1mSt8SWrwf_HMfOCRg_oENioc1rkvQ/edit# We have a universal export now. Why would we ask for logs only? Reviewed By: passy Differential Revision: D40553127 fbshipit-source-id: 674482e39746e789d70bf800daa5f021d83bb093 --- desktop/flipper-ui-core/src/sandy-chrome/LeftRail.tsx | 11 ----------- desktop/flipper-ui-core/src/utils/exportData.tsx | 7 ------- 2 files changed, 18 deletions(-) diff --git a/desktop/flipper-ui-core/src/sandy-chrome/LeftRail.tsx b/desktop/flipper-ui-core/src/sandy-chrome/LeftRail.tsx index d42c54990..04134fbdb 100644 --- a/desktop/flipper-ui-core/src/sandy-chrome/LeftRail.tsx +++ b/desktop/flipper-ui-core/src/sandy-chrome/LeftRail.tsx @@ -72,7 +72,6 @@ import { showOpenDialog, startFileExport, startLinkExport, - startFlipperLogsExport, ExportEverythingEverywhereAllAtOnceStatus, } from '../utils/exportData'; import {openDeeplinkDialog} from '../deeplink'; @@ -238,11 +237,6 @@ function ExtrasMenu() { () => startFileExport(store.dispatch), [store.dispatch], ); - const startLogsExportTracked = useTrackedCallback( - 'Logs export', - startFlipperLogsExport, - [], - ); const startLinkExportTracked = useTrackedCallback( 'Link export', () => startLinkExport(store.dispatch), @@ -278,11 +272,6 @@ function ExtrasMenu() { key="extras" title={} small />} className={submenu}> - {canFileExport() ? ( - - Export Flipper logs - - ) : null} {canOpenDialog() ? ( Import Flipper file diff --git a/desktop/flipper-ui-core/src/utils/exportData.tsx b/desktop/flipper-ui-core/src/utils/exportData.tsx index c5dbfd076..5a21e20df 100644 --- a/desktop/flipper-ui-core/src/utils/exportData.tsx +++ b/desktop/flipper-ui-core/src/utils/exportData.tsx @@ -613,13 +613,6 @@ export function canFileExport() { return !!getRenderHostInstance().showSaveDialog; } -export async function startFlipperLogsExport() { - const serializedLogs = exportLogs - .map((item) => JSON.stringify(item)) - .join('\n'); - await getRenderHostInstance().exportFile?.(serializedLogs); -} - async function startDeviceFlipperFolderExport() { return await getRenderHostInstance().flipperServer.exec( {timeout: 3 * 60 * 1000},