Proposal: Make AppInspect open on click

Summary:
This addresses my biggest gripe with Flipper right now (maybe after it occasionally crashing my entire Mac, but that's beyond our control, sadly). When you try to switch your current device and hover over the picker, move your mouse quickly to where you expect the menu to open, it will immediate close. You have to wait for about 200ms before moving your cursor down into the expanded dropdown menu. "Well, it's only 200ms, Passy, chill." That's fair, but I still think that hovering to open a dropdown is unnatural behaviour. Looking around here in Phabricator, none of the dropdowns behave like this. And they definitely don't just disappear under my cursor if I'm Moving (too) Fast.

Changelog: The app selector no longer reacts on hover events now requites a click

Reviewed By: mweststrate

Differential Revision: D28118657

fbshipit-source-id: 67867d597b21b80a0de87ecbc8c86a7334f81952
This commit is contained in:
Pascal Hartig
2021-04-30 07:32:26 -07:00
committed by Facebook GitHub Bot
parent 2520e6912f
commit 1447ae0c18

View File

@@ -97,6 +97,7 @@ export function AppSelector() {
flex: 1,
}}>
<Dropdown
trigger={['click']}
overlay={
<Menu selectedKeys={selectedApp ? [selectedApp] : []}>{entries}</Menu>
}>