jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename skip_view_traversal setting

Browse Source 
Summary: Sonar -> Flipper. 'nuff said.

Reviewed By: danielbuechele

Differential Revision: D9940670

fbshipit-source-id: ed9c8267c0c32952ac2069dc25bdb5359a438ce5
This commit is contained in:
Pascal Hartig
2018-09-19 13:04:55 -07:00
committed by Facebook Github Bot
parent 22742fd563
commit 0e753e684f
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewGroupDescriptor.java
View File

@@ -287,7 +287,7 @@ public class ViewGroupDescriptor extends NodeDescriptor<ViewGroup> {
} }
private static boolean shouldSkip(View view) { private static boolean shouldSkip(View view) {
Object tag = view.getTag(R.id.sonar_skip_view_traversal); Object tag = view.getTag(R.id.flipper_skip_view_traversal);
if (!(tag instanceof Boolean)) { if (!(tag instanceof Boolean)) {
return false; return false;
} }

2
android/src/main/res/values/ids.xml
View File

@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<resources> <resources>
<item type="id" name="sonar_skip_view_traversal"/> <item type="id" name="flipper_skip_view_traversal"/>
</resources> </resources>

2
docs/layout-plugin.md
View File

@@ -88,7 +88,7 @@ The issue is that if you have some view that occupies big part of the screen but
Add the following tag to your view to skip it from Flipper's view picker. The view will still be shown in the layout hierarchy, but it will not be selected while using the view picker. Add the following tag to your view to skip it from Flipper's view picker. The view will still be shown in the layout hierarchy, but it will not be selected while using the view picker.
```java ```java
view.setTag("sonar_skip_view_traversal", true); view.setTag("flipper_skip_view_traversal", true);
``` ```
## Accessibility mode (Android-only) ## Accessibility mode (Android-only)