From 0e753e684f6dfcc6ee750fb02bc24e08406b34da Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Wed, 19 Sep 2018 13:04:55 -0700 Subject: [PATCH] Rename skip_view_traversal setting Summary: Sonar -> Flipper. 'nuff said. Reviewed By: danielbuechele Differential Revision: D9940670 fbshipit-source-id: ed9c8267c0c32952ac2069dc25bdb5359a438ce5 --- .../plugins/inspector/descriptors/ViewGroupDescriptor.java | 2 +- android/src/main/res/values/ids.xml | 2 +- docs/layout-plugin.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewGroupDescriptor.java b/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewGroupDescriptor.java index e1e544342..8f048920a 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewGroupDescriptor.java +++ b/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewGroupDescriptor.java @@ -287,7 +287,7 @@ public class ViewGroupDescriptor extends NodeDescriptor { } private static boolean shouldSkip(View view) { - Object tag = view.getTag(R.id.sonar_skip_view_traversal); + Object tag = view.getTag(R.id.flipper_skip_view_traversal); if (!(tag instanceof Boolean)) { return false; } diff --git a/android/src/main/res/values/ids.xml b/android/src/main/res/values/ids.xml index 6d454c931..9ffd4b56a 100644 --- a/android/src/main/res/values/ids.xml +++ b/android/src/main/res/values/ids.xml @@ -1,4 +1,4 @@ - + diff --git a/docs/layout-plugin.md b/docs/layout-plugin.md index 9e8fe3a24..4226a4f2b 100644 --- a/docs/layout-plugin.md +++ b/docs/layout-plugin.md @@ -88,7 +88,7 @@ The issue is that if you have some view that occupies big part of the screen but Add the following tag to your view to skip it from Flipper's view picker. The view will still be shown in the layout hierarchy, but it will not be selected while using the view picker. ```java -view.setTag("sonar_skip_view_traversal", true); +view.setTag("flipper_skip_view_traversal", true); ``` ## Accessibility mode (Android-only)