jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Plugin RPC errors should not cause crash report

Browse Source 
Summary:
This code path is when a send results in an error being returned from the client.  We reject the promise but also raise an error on the message bus.

There is a handler for this 'error' event that is raised that is over zelous and reports a crash to the crash reporter. This should not happen

Reviewed By: lblasa

Differential Revision: D42385292

fbshipit-source-id: f668a396b0d266ee9d1c7c1ca740e7bb5ae9608a
This commit is contained in:
Luke De Feo
2023-01-06 06:15:44 -08:00
committed by Facebook GitHub Bot
parent 2f4c88c8d1
commit 0a693f710e
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
desktop/flipper-frontend-core/src/AbstractClient.tsx
View File

@@ -327,12 +327,6 @@ export default abstract class AbstractClient extends EventEmitter {
resolve && resolve(data.success); resolve && resolve(data.success);
} else if (data.error) { } else if (data.error) {
reject(data.error); reject(data.error);
const {error} = data;
if (error) {
this.emit('error', error);
}
} else {
// ???
} }
} }