From 0a693f710ea1f81fc21fe158f1ccde9b3fbc8c7f Mon Sep 17 00:00:00 2001 From: Luke De Feo Date: Fri, 6 Jan 2023 06:15:44 -0800 Subject: [PATCH] Plugin RPC errors should not cause crash report Summary: This code path is when a send results in an error being returned from the client. We reject the promise but also raise an error on the message bus. There is a handler for this 'error' event that is raised that is over zelous and reports a crash to the crash reporter. This should not happen Reviewed By: lblasa Differential Revision: D42385292 fbshipit-source-id: f668a396b0d266ee9d1c7c1ca740e7bb5ae9608a --- desktop/flipper-frontend-core/src/AbstractClient.tsx | 6 ------ 1 file changed, 6 deletions(-) diff --git a/desktop/flipper-frontend-core/src/AbstractClient.tsx b/desktop/flipper-frontend-core/src/AbstractClient.tsx index dfaef0a4b..85e8cb72e 100644 --- a/desktop/flipper-frontend-core/src/AbstractClient.tsx +++ b/desktop/flipper-frontend-core/src/AbstractClient.tsx @@ -327,12 +327,6 @@ export default abstract class AbstractClient extends EventEmitter { resolve && resolve(data.success); } else if (data.error) { reject(data.error); - const {error} = data; - if (error) { - this.emit('error', error); - } - } else { - // ??? } }