rename fill attribute
Summary:
We were using `fill={true}` as an attribute to make flexbox containers fill the entire available space.
However, `fill` is an HTML attribute (see: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/fill) This caused warnings printed to the console.
This diff renames the attribute to `grow` with is also more in line with the Flexbox terminology.
Reviewed By: priteshrnandgaonkar
Differential Revision: D10488389
fbshipit-source-id: ed8553c6203cdf6df94d26c731164ecec4c9fbd2
This commit is contained in:
committed by
Facebook Github Bot
parent
2a179b9d3c
commit
086ab0188b
@@ -200,7 +200,7 @@ export default class extends FlipperPlugin<SharedPreferencesState> {
|
||||
}
|
||||
|
||||
return (
|
||||
<RootColumn fill={true}>
|
||||
<RootColumn grow={true}>
|
||||
<Heading>
|
||||
<span style={{marginRight: '16px'}}>Preference File</span>
|
||||
<Select
|
||||
@@ -214,7 +214,7 @@ export default class extends FlipperPlugin<SharedPreferencesState> {
|
||||
onChange={this.onSharedPreferencesSelected}
|
||||
/>
|
||||
</Heading>
|
||||
<FlexRow fill={true} scrollable={true}>
|
||||
<FlexRow grow={true} scrollable={true}>
|
||||
<InspectorColumn>
|
||||
<Heading>Inspector</Heading>
|
||||
<ManagedDataInspector
|
||||
|
||||
Reference in New Issue
Block a user