From 086ab0188b4171c45d873eda1c610e157262e721 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20B=C3=BCchele?= <danielbuechele@fb.com>
Date: Mon, 22 Oct 2018 09:52:19 -0700
Subject: [PATCH] rename fill attribute

Summary:
We were using `fill={true}` as an attribute to make flexbox containers fill the entire available space.

However, `fill` is an HTML attribute (see: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/fill) This caused warnings printed to the console.

This diff renames the attribute to `grow` with is also more in line with the Flexbox terminology.

Reviewed By: priteshrnandgaonkar

Differential Revision: D10488389

fbshipit-source-id: ed8553c6203cdf6df94d26c731164ecec4c9fbd2
---
 src/App.js                                           |  4 ++--
 src/__tests__/__snapshots__/App.electron.js.snap     |  2 --
 src/chrome/BugReporterDialog.js                      |  4 ++--
 src/chrome/PluginManager.js                          |  4 ++--
 src/createTablePlugin.js                             |  2 +-
 src/plugins/cpu/index.js                             |  2 +-
 src/plugins/layout/index.js                          |  6 +++---
 src/plugins/leak_canary/index.js                     |  8 ++++----
 src/plugins/logs/LogWatcher.js                       |  2 +-
 src/plugins/network/index.js                         |  2 +-
 src/plugins/sandbox/index.js                         |  2 +-
 src/plugins/shared_preferences/index.js              |  4 ++--
 src/ui/components/ErrorBoundary.js                   |  2 +-
 src/ui/components/Interactive.js                     |  8 ++++----
 src/ui/components/Panel.js                           | 12 ++++++------
 src/ui/components/Tabs.js                            |  2 +-
 src/ui/components/View.js                            |  4 ++--
 src/ui/components/VirtualList.js                     |  2 +-
 src/ui/components/console.js                         |  2 +-
 .../elements-inspector/ElementsInspector.js          |  2 +-
 src/ui/components/elements-inspector/sidebar.js      |  4 ++--
 src/ui/components/intro/intro.js                     |  2 +-
 src/ui/components/table/TableHead.js                 |  2 +-
 23 files changed, 41 insertions(+), 43 deletions(-)

diff --git a/src/App.js b/src/App.js
index 688e478e2..da3d2384c 100644
--- a/src/App.js
+++ b/src/App.js
@@ -49,7 +49,7 @@ export class App extends React.Component<Props> {
   }
   render() {
     return (
-      <FlexColumn fill={true}>
+      <FlexColumn grow={true}>
         <TitleBar />
         {this.props.bugDialogVisible && (
           <BugReporterDialog
@@ -59,7 +59,7 @@ export class App extends React.Component<Props> {
             }}
           />
         )}
-        <FlexRow fill={true}>
+        <FlexRow grow={true}>
           {this.props.leftSidebarVisible && <MainSidebar />}
           {this.props.selectedDevice ? (
             <PluginContainer logger={this.props.logger} />
diff --git a/src/__tests__/__snapshots__/App.electron.js.snap b/src/__tests__/__snapshots__/App.electron.js.snap
index 3eb77b1a2..8c1b8591a 100644
--- a/src/__tests__/__snapshots__/App.electron.js.snap
+++ b/src/__tests__/__snapshots__/App.electron.js.snap
@@ -3,7 +3,6 @@
 exports[`Empty app state matches snapshot 1`] = `
 <div
   className="css-1si6n3e"
-  fill={true}
 >
   <div
     className="toolbar css-1u64wvw"
@@ -113,7 +112,6 @@ exports[`Empty app state matches snapshot 1`] = `
   </div>
   <div
     className="css-9qtipk"
-    fill={true}
   >
     <div
       className="css-1atbcdi"
diff --git a/src/chrome/BugReporterDialog.js b/src/chrome/BugReporterDialog.js
index e20014c01..8226ca7b5 100644
--- a/src/chrome/BugReporterDialog.js
+++ b/src/chrome/BugReporterDialog.js
@@ -183,7 +183,7 @@ export default class BugReporterDialog extends Component<Props, State> {
 
     if (success) {
       content = (
-        <FlexCenter fill={true}>
+        <FlexCenter grow={true}>
           <FlexColumn>
             <Text>
               <Text>Bug </Text>
@@ -204,7 +204,7 @@ export default class BugReporterDialog extends Component<Props, State> {
       );
     } else {
       content = (
-        <Container fill={true}>
+        <Container grow={true}>
           <TitleInput
             placeholder="Title..."
             value={title}
diff --git a/src/chrome/PluginManager.js b/src/chrome/PluginManager.js
index 186e46ab6..0a9efcd7f 100644
--- a/src/chrome/PluginManager.js
+++ b/src/chrome/PluginManager.js
@@ -343,7 +343,7 @@ class PluginManager extends PureComponent<Props, State> {
     );
     return (
       <Container>
-        <FlexColumn fill={true}>
+        <FlexColumn grow={true}>
           {this.state.restartRequired && (
             <RestartRequired onClick={this.relaunch}>
               <Glyph name="arrows-circle" size={12} color={colors.white} />
@@ -396,7 +396,7 @@ const SearchablePluginManager = Searchable(PluginManager);
 export default class extends PureComponent<{}> {
   render() {
     return (
-      <FlexColumn fill={true}>
+      <FlexColumn grow={true}>
         <SearchablePluginManager />
       </FlexColumn>
     );
diff --git a/src/createTablePlugin.js b/src/createTablePlugin.js
index 0461baa63..2fb3d1f93 100644
--- a/src/createTablePlugin.js
+++ b/src/createTablePlugin.js
@@ -185,7 +185,7 @@ export function createTablePlugin<T: RowData>(props: Props<T>) {
       const {rows} = this.state;
 
       return (
-        <FlexColumn fill={true}>
+        <FlexColumn grow={true}>
           <SearchableTable
             key={props.id}
             rowLineHeight={28}
diff --git a/src/plugins/cpu/index.js b/src/plugins/cpu/index.js
index 4e2f9ca89..c9dbab27f 100644
--- a/src/plugins/cpu/index.js
+++ b/src/plugins/cpu/index.js
@@ -340,7 +340,7 @@ export default class CPUFrequencyTable extends FlipperDevicePlugin<CPUState> {
   render() {
     return (
       <FlexRow>
-        <FlexColumn fill={true}>
+        <FlexColumn grow={true}>
           <Toolbar position="top">
             {this.state.monitoring ? (
               <Button onClick={this.onStopMonitor} icon="pause">
diff --git a/src/plugins/layout/index.js b/src/plugins/layout/index.js
index 2c37cb780..0ccfd0ade 100644
--- a/src/plugins/layout/index.js
+++ b/src/plugins/layout/index.js
@@ -1120,7 +1120,7 @@ export default class Layout extends FlipperPlugin<InspectorState> {
     } = this.state;
 
     return (
-      <FlexColumn fill={true}>
+      <FlexColumn grow={true}>
         <Toolbar>
           <SearchIconContainer
             onClick={this.onFindClick}
@@ -1197,7 +1197,7 @@ export default class Layout extends FlipperPlugin<InspectorState> {
               </SearchIconContainer>
             )}
         </Toolbar>
-        <FlexRow fill={true}>
+        <FlexRow grow={true}>
           {initialised ? (
             <ElementsInspector
               onElementSelected={this.onElementSelected}
@@ -1210,7 +1210,7 @@ export default class Layout extends FlipperPlugin<InspectorState> {
               elements={elements}
             />
           ) : (
-            <Center fill={true}>
+            <Center grow={true}>
               <LoadingIndicator />
             </Center>
           )}
diff --git a/src/plugins/leak_canary/index.js b/src/plugins/leak_canary/index.js
index dd04ba886..1bb133fb9 100644
--- a/src/plugins/leak_canary/index.js
+++ b/src/plugins/leak_canary/index.js
@@ -147,14 +147,14 @@ export default class LeakCanary extends FlipperPlugin<State> {
 
     return (
       <Sidebar position="right" width={600} minWidth={300} maxWidth={900}>
-        <Panel heading={'Instance'} floating={false} fill={false}>
+        <Panel heading={'Instance'} floating={false} grow={false}>
           <ManagedDataInspector
             data={instanceFields}
             expandRoot={true}
             extractValue={this._extractValue}
           />
         </Panel>
-        <Panel heading={'Static'} floating={false} fill={false}>
+        <Panel heading={'Static'} floating={false} grow={false}>
           <ManagedDataInspector
             data={staticFields}
             expandRoot={true}
@@ -171,8 +171,8 @@ export default class LeakCanary extends FlipperPlugin<State> {
 
     return (
       <Window>
-        <FlexColumn fill={true}>
-          <FlexColumn fill={true} scrollable={true}>
+        <FlexColumn grow={true}>
+          <FlexColumn grow={true} scrollable={true}>
             {this.state.leaks.map((leak: Leak, idx: number) => {
               const elements = showFullClassPaths
                 ? leak.elements
diff --git a/src/plugins/logs/LogWatcher.js b/src/plugins/logs/LogWatcher.js
index 905f88be2..63f8ccf0d 100644
--- a/src/plugins/logs/LogWatcher.js
+++ b/src/plugins/logs/LogWatcher.js
@@ -188,7 +188,7 @@ export default class LogWatcher extends PureComponent<Props, State> {
 
   render() {
     return (
-      <FlexColumn fill={true} tabIndex={-1} onKeyDown={this.onKeyDown}>
+      <FlexColumn grow={true} tabIndex={-1} onKeyDown={this.onKeyDown}>
         <WatcherPanel
           heading="Expression Watcher"
           floating={false}
diff --git a/src/plugins/network/index.js b/src/plugins/network/index.js
index 3bb7d90f9..32d461eae 100644
--- a/src/plugins/network/index.js
+++ b/src/plugins/network/index.js
@@ -197,7 +197,7 @@ export default class extends FlipperPlugin<State, *, PersistedState> {
     const {requests, responses} = this.props.persistedState;
 
     return (
-      <FlexColumn fill={true}>
+      <FlexColumn grow={true}>
         <NetworkTable
           requests={requests || {}}
           responses={responses || {}}
diff --git a/src/plugins/sandbox/index.js b/src/plugins/sandbox/index.js
index 735e84707..1ad2799e8 100644
--- a/src/plugins/sandbox/index.js
+++ b/src/plugins/sandbox/index.js
@@ -103,7 +103,7 @@ export default class SandboxView extends FlipperPlugin<SandboxState> {
     return (
       <FlexColumn>
         <SandboxView.TextInputLayout>
-          <ButtonGroup flexGrow={1}>
+          <ButtonGroup flexgrow={true}>
             <SandboxView.TextInput
               type="text"
               placeholder="Sandbox URL (e.g. unixname.sb.facebook.com)"
diff --git a/src/plugins/shared_preferences/index.js b/src/plugins/shared_preferences/index.js
index 1796af5ca..dc171fa30 100644
--- a/src/plugins/shared_preferences/index.js
+++ b/src/plugins/shared_preferences/index.js
@@ -200,7 +200,7 @@ export default class extends FlipperPlugin<SharedPreferencesState> {
     }
 
     return (
-      <RootColumn fill={true}>
+      <RootColumn grow={true}>
         <Heading>
           <span style={{marginRight: '16px'}}>Preference File</span>
           <Select
@@ -214,7 +214,7 @@ export default class extends FlipperPlugin<SharedPreferencesState> {
             onChange={this.onSharedPreferencesSelected}
           />
         </Heading>
-        <FlexRow fill={true} scrollable={true}>
+        <FlexRow grow={true} scrollable={true}>
           <InspectorColumn>
             <Heading>Inspector</Heading>
             <ManagedDataInspector
diff --git a/src/ui/components/ErrorBoundary.js b/src/ui/components/ErrorBoundary.js
index d8bf7b42e..ed5f888dd 100644
--- a/src/ui/components/ErrorBoundary.js
+++ b/src/ui/components/ErrorBoundary.js
@@ -66,7 +66,7 @@ export default class ErrorBoundary extends Component<
       }
 
       return (
-        <ErrorBoundaryContainer fill={true}>
+        <ErrorBoundaryContainer grow={true}>
           <Heading>{heading}</Heading>
           {this.props.showStack !== false && (
             <ErrorBoundaryStack error={error} />
diff --git a/src/ui/components/Interactive.js b/src/ui/components/Interactive.js
index 4be1240c7..cb156d262 100644
--- a/src/ui/components/Interactive.js
+++ b/src/ui/components/Interactive.js
@@ -48,7 +48,7 @@ type InteractiveProps = {|
   movable?: boolean,
   hidden?: boolean,
   moving?: boolean,
-  fill?: boolean,
+  grow?: boolean,
   siblings?: $Shape<{[key: string]: $Shape<Rect>}>,
   updateCursor?: (cursor: ?string) => void,
   zIndex?: number,
@@ -650,7 +650,7 @@ export default class Interactive extends React.Component<
   };
 
   render() {
-    const {fill, height, left, movable, top, width, zIndex} = this.props;
+    const {grow, height, left, movable, top, width, zIndex} = this.props;
 
     const style: Object = {
       cursor: this.state.cursor,
@@ -658,7 +658,7 @@ export default class Interactive extends React.Component<
     };
 
     if (movable === true || top != null || left != null) {
-      if (fill === true) {
+      if (grow === true) {
         style.left = left || 0;
         style.top = top || 0;
       } else {
@@ -666,7 +666,7 @@ export default class Interactive extends React.Component<
       }
     }
 
-    if (fill === true) {
+    if (grow === true) {
       style.right = 0;
       style.bottom = 0;
       style.width = '100%';
diff --git a/src/ui/components/Panel.js b/src/ui/components/Panel.js
index 9664b36e8..aec25ab0e 100644
--- a/src/ui/components/Panel.js
+++ b/src/ui/components/Panel.js
@@ -40,7 +40,7 @@ export default class Panel extends React.Component<
      *  height: 100%;
      *  width: 100%;
      */
-    fill?: boolean,
+    grow?: boolean,
     /**
      * Heading for this panel. If this is anything other than a string then no
      * padding is applied to the heading.
@@ -74,10 +74,10 @@ export default class Panel extends React.Component<
 > {
   static defaultProps: {|
     floating: boolean,
-    fill: boolean,
+    grow: boolean,
     collapsable: boolean,
   |} = {
-    fill: false,
+    grow: false,
     floating: true,
     collapsable: true,
   };
@@ -124,7 +124,7 @@ export default class Panel extends React.Component<
       padded,
       children,
       className,
-      fill,
+      grow,
       floating,
       heading,
       collapsable,
@@ -135,7 +135,7 @@ export default class Panel extends React.Component<
       <Panel.PanelContainer
         className={className}
         floating={floating}
-        fill={fill}
+        grow={grow}
         collapsed={collapsed}>
         <Panel.PanelHeader
           floating={floating}
@@ -156,7 +156,7 @@ export default class Panel extends React.Component<
 
         {children == null || (collapsable && collapsed) ? null : (
           <Panel.PanelBody
-            fill={fill}
+            grow={grow}
             padded={padded == null ? true : padded}
             floating={floating}>
             {children}
diff --git a/src/ui/components/Tabs.js b/src/ui/components/Tabs.js
index 45aa12b22..7e0d43e7e 100644
--- a/src/ui/components/Tabs.js
+++ b/src/ui/components/Tabs.js
@@ -251,7 +251,7 @@ export default function Tabs(props: {|
   }
 
   return (
-    <FlexColumn fill={true}>
+    <FlexColumn grow={true}>
       <TabList>
         {before}
         {tabList}
diff --git a/src/ui/components/View.js b/src/ui/components/View.js
index ee8e67b16..c04e94d81 100644
--- a/src/ui/components/View.js
+++ b/src/ui/components/View.js
@@ -8,10 +8,10 @@
 import styled from '../styled/index.js';
 
 const View = styled('div')(props => ({
-  height: props.fill ? '100%' : 'auto',
+  height: props.grow ? '100%' : 'auto',
   overflow: props.scrollable ? 'auto' : 'visible',
   position: 'relative',
-  width: props.fill ? '100%' : 'auto',
+  width: props.grow ? '100%' : 'auto',
 }));
 
 export default View;
diff --git a/src/ui/components/VirtualList.js b/src/ui/components/VirtualList.js
index 7723da35b..924ee761f 100644
--- a/src/ui/components/VirtualList.js
+++ b/src/ui/components/VirtualList.js
@@ -126,7 +126,7 @@ export default class VirtualList extends Component<
 
     return (
       <View
-        fill={true}
+        grow={true}
         onScroll={this.handleScroll}
         innerRef={this.setRef}
         scrollable={true}>
diff --git a/src/ui/components/console.js b/src/ui/components/console.js
index 28509a620..f434675cb 100644
--- a/src/ui/components/console.js
+++ b/src/ui/components/console.js
@@ -197,7 +197,7 @@ export class Console extends Component<Props, State> {
   render() {
     return (
       <Console.Window>
-        <View fill>{this.renderPreviousCommands()}</View>
+        <View grow={true}>{this.renderPreviousCommands()}</View>
         <form onSubmit={this.onSubmit}>
           <Console.Input
             onChange={this.onInputChange}
diff --git a/src/ui/components/elements-inspector/ElementsInspector.js b/src/ui/components/elements-inspector/ElementsInspector.js
index 5f35ec8d0..1fa9f2416 100644
--- a/src/ui/components/elements-inspector/ElementsInspector.js
+++ b/src/ui/components/elements-inspector/ElementsInspector.js
@@ -84,7 +84,7 @@ export default class ElementsInspector extends Component<{
     } = this.props;
 
     return (
-      <FlexRow fill={true}>
+      <FlexRow grow={true}>
         <Elements
           onElementExpanded={onElementExpanded}
           onElementSelected={onElementSelected}
diff --git a/src/ui/components/elements-inspector/sidebar.js b/src/ui/components/elements-inspector/sidebar.js
index 24808eed8..41d124080 100644
--- a/src/ui/components/elements-inspector/sidebar.js
+++ b/src/ui/components/elements-inspector/sidebar.js
@@ -59,7 +59,7 @@ class InspectorSidebarSection extends Component<InspectorSidebarSectionProps> {
   render() {
     const {id} = this.props;
     return (
-      <Panel heading={id} floating={false} fill={false}>
+      <Panel heading={id} floating={false} grow={false}>
         <ManagedDataInspector
           data={this.props.data}
           setValue={this.props.onValueChanged ? this.setValue : undefined}
@@ -137,7 +137,7 @@ export class InspectorSidebar extends Component<Props, State> {
 
     if (GK.get('sonar_show_console_plugin') && this.state.isConsoleEnabled) {
       sections.push(
-        <Panel heading="JS Console" floating={false} fill={false}>
+        <Panel heading="JS Console" floating={false} grow={false}>
           <Console client={this.props.client} getContext={() => element.id} />
         </Panel>,
       );
diff --git a/src/ui/components/intro/intro.js b/src/ui/components/intro/intro.js
index 107a5af0c..480180945 100644
--- a/src/ui/components/intro/intro.js
+++ b/src/ui/components/intro/intro.js
@@ -87,7 +87,7 @@ export default class Intro extends PureComponent<Props> {
   render() {
     const {icon, children, title, onDismiss, screenshot} = this.props;
     return (
-      <FlexRow fill={true}>
+      <FlexRow grow={true}>
         <Containter>
           <TitleRow>
             {icon != null && (
diff --git a/src/ui/components/table/TableHead.js b/src/ui/components/table/TableHead.js
index 5bd6a3e27..03e12f870 100644
--- a/src/ui/components/table/TableHead.js
+++ b/src/ui/components/table/TableHead.js
@@ -164,7 +164,7 @@ class TableHeadColumn extends PureComponent<{
     if (isResizable) {
       children = (
         <TableHeaderColumnInteractive
-          fill={true}
+          grow={true}
           resizable={RIGHT_RESIZABLE}
           onResize={this.onResize}>
           {children}