rename fill attribute
Summary:
We were using `fill={true}` as an attribute to make flexbox containers fill the entire available space.
However, `fill` is an HTML attribute (see: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/fill) This caused warnings printed to the console.
This diff renames the attribute to `grow` with is also more in line with the Flexbox terminology.
Reviewed By: priteshrnandgaonkar
Differential Revision: D10488389
fbshipit-source-id: ed8553c6203cdf6df94d26c731164ecec4c9fbd2
This commit is contained in:
committed by
Facebook Github Bot
parent
2a179b9d3c
commit
086ab0188b
@@ -147,14 +147,14 @@ export default class LeakCanary extends FlipperPlugin<State> {
|
||||
|
||||
return (
|
||||
<Sidebar position="right" width={600} minWidth={300} maxWidth={900}>
|
||||
<Panel heading={'Instance'} floating={false} fill={false}>
|
||||
<Panel heading={'Instance'} floating={false} grow={false}>
|
||||
<ManagedDataInspector
|
||||
data={instanceFields}
|
||||
expandRoot={true}
|
||||
extractValue={this._extractValue}
|
||||
/>
|
||||
</Panel>
|
||||
<Panel heading={'Static'} floating={false} fill={false}>
|
||||
<Panel heading={'Static'} floating={false} grow={false}>
|
||||
<ManagedDataInspector
|
||||
data={staticFields}
|
||||
expandRoot={true}
|
||||
@@ -171,8 +171,8 @@ export default class LeakCanary extends FlipperPlugin<State> {
|
||||
|
||||
return (
|
||||
<Window>
|
||||
<FlexColumn fill={true}>
|
||||
<FlexColumn fill={true} scrollable={true}>
|
||||
<FlexColumn grow={true}>
|
||||
<FlexColumn grow={true} scrollable={true}>
|
||||
{this.state.leaks.map((leak: Leak, idx: number) => {
|
||||
const elements = showFullClassPaths
|
||||
? leak.elements
|
||||
|
||||
Reference in New Issue
Block a user