Files
flipper/xplat/FlipperTests/FlipperClientTests.cpp
Michel Weststrate b9c3d99f44 Stop connecting disabled background plugins
Summary:
Background for this diff: https://fb.quip.com/KqEfAlKYlgme

Some plugins don't respect that stuff (livefeed and graphql), but for others it seems to work fine.

This is just a PoC, there are some present bugs concerning the combination of selecting and bg plugins

Questions to investigate:

- [x] make sure that LiveFeed and GraphQL disconnect properly. There might be more plugins that need that
- [x] verifiy that we don't loose one of the original goals of background plugins, e.g. QPL collecting and sending data from device start. Does this still work as intended after this change?
- [x] how can we observe / measure improvements? Are dev builds more responsive after this? Is the layout inspector smoother for example because no QPL plugins are interweaved?
- [x] how is forward and backward compatibility?
   - If Flipper is updated, but device not: No change I think, as getBackgroundPlugins() will return an empty set, and background plugins are initiated as usual, so old behavior
  - If device is updated, but Flipper not, background plugins won't be started until they are selected. This is a degradation, but hopefully explainable.
- [x] Verify QPL buffer is not unbounded
- [x] Share architecutre changes with team

For Graphql updates: D20943455

Added runtime stats to monitor network traffic (sadly had to redo that since scuba couldn't handle the data format used at first, so probably will hold of landing this diff a week to make sure we can see some effects)

Follow up work:

[x] wait until we released the stat tracking before we release this, to be able to measure the effect?
[x] make sure graphql fix lands
[ ] use side effects abstraction
[ ] fix other background plugins (android only) or fix it in a generic way:

{F234394286}

Changelog: Background plugins will no longer receive a Flipper connection if they are disabled. This should significantly reduce the overall load of Flipper both on the device and desktop when unused plugins are disabled used, which could otherwise generate 10MB/s of network traffic certain scenarios. All plugins *should* be able to handle to this gracefully, but since this is quite a fundamental change, reach out to the Flipper team when in doubt!

Reviewed By: jknoxville

Differential Revision: D20942453

fbshipit-source-id: b699199cb95c1b3e4c36e026b6dfaee7d1652e1f
2020-04-27 09:46:13 -07:00

404 lines
13 KiB
C++

/*
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
#include <Flipper/FlipperClient.h>
#include <FlipperTestLib/FlipperConnectionManagerMock.h>
#include <FlipperTestLib/FlipperPluginMock.h>
#include <FlipperTestLib/FlipperResponderMock.h>
#include <folly/json.h>
#include <gtest/gtest.h>
namespace facebook {
namespace flipper {
namespace test {
using folly::dynamic;
class FlipperClientTest : public ::testing::Test {
protected:
std::unique_ptr<FlipperClient> client;
FlipperConnectionManagerMock* socket;
std::shared_ptr<FlipperState> state;
std::vector<folly::dynamic> successes;
std::vector<folly::dynamic> failures;
void SetUp() override {
successes.clear();
failures.clear();
state.reset(new FlipperState());
socket = new FlipperConnectionManagerMock;
client = std::make_unique<FlipperClient>(
std::unique_ptr<FlipperConnectionManagerMock>{socket}, state);
}
std::unique_ptr<FlipperResponderMock> getResponder() {
return std::make_unique<FlipperResponderMock>(&successes, &failures);
}
};
TEST_F(FlipperClientTest, testSaneMocks) {
FlipperConnectionManagerMock socket;
socket.start();
EXPECT_TRUE(socket.isOpen());
socket.stop();
EXPECT_FALSE(socket.isOpen());
FlipperPluginMock plugin("Test");
EXPECT_EQ(plugin.identifier(), "Test");
}
TEST_F(FlipperClientTest, testGetPlugins) {
client->start();
client->addPlugin(std::make_shared<FlipperPluginMock>("Cat"));
client->addPlugin(std::make_shared<FlipperPluginMock>("Dog"));
dynamic message = dynamic::object("id", 1)("method", "getPlugins");
socket->onMessageReceived(message, getResponder());
dynamic expected = dynamic::object("plugins", dynamic::array("Cat", "Dog"));
EXPECT_EQ(successes[0], expected);
EXPECT_EQ(failures.size(), 0);
}
TEST_F(FlipperClientTest, testGetPlugin) {
const auto catPlugin = std::make_shared<FlipperPluginMock>("Cat");
client->addPlugin(catPlugin);
const auto dogPlugin = std::make_shared<FlipperPluginMock>("Dog");
client->addPlugin(dogPlugin);
EXPECT_EQ(catPlugin, client->getPlugin("Cat"));
EXPECT_EQ(dogPlugin, client->getPlugin("Dog"));
}
TEST_F(FlipperClientTest, testGetPluginWithDowncast) {
const auto catPlugin = std::make_shared<FlipperPluginMock>("Cat");
client->addPlugin(catPlugin);
EXPECT_EQ(catPlugin, client->getPlugin<FlipperPluginMock>("Cat"));
}
TEST_F(FlipperClientTest, testRemovePlugin) {
client->start();
auto plugin = std::make_shared<FlipperPluginMock>("Test");
client->addPlugin(plugin);
client->removePlugin(plugin);
dynamic message = dynamic::object("id", 1)("method", "getPlugins");
auto responder = std::make_unique<FlipperResponderMock>();
socket->onMessageReceived(message, getResponder());
dynamic expected = dynamic::object("plugins", dynamic::array());
EXPECT_EQ(successes[0], expected);
EXPECT_EQ(failures.size(), 0);
}
TEST_F(FlipperClientTest, testStartStop) {
client->start();
EXPECT_TRUE(socket->isOpen());
client->stop();
EXPECT_FALSE(socket->isOpen());
}
TEST_F(FlipperClientTest, testConnectDisconnect) {
bool pluginConnected = false;
const auto connectionCallback = [&](std::shared_ptr<FlipperConnection> conn) {
pluginConnected = true;
};
const auto disconnectionCallback = [&]() { pluginConnected = false; };
auto plugin = std::make_shared<FlipperPluginMock>(
"Test", connectionCallback, disconnectionCallback);
client->addPlugin(plugin);
client->start();
dynamic messageInit = dynamic::object("method", "init")(
"params", dynamic::object("plugin", "Test"));
auto responder = std::make_shared<FlipperResponderMock>();
socket->callbacks->onMessageReceived(messageInit, getResponder());
EXPECT_TRUE(pluginConnected);
client->stop();
EXPECT_FALSE(pluginConnected);
}
TEST_F(FlipperClientTest, testInitDeinit) {
bool pluginConnected = false;
const auto connectionCallback = [&](std::shared_ptr<FlipperConnection> conn) {
pluginConnected = true;
};
const auto disconnectionCallback = [&]() { pluginConnected = false; };
auto plugin = std::make_shared<FlipperPluginMock>(
"Test", connectionCallback, disconnectionCallback);
client->start();
client->addPlugin(plugin);
EXPECT_FALSE(pluginConnected);
dynamic expected = dynamic::object("method", "refreshPlugins");
EXPECT_EQ(socket->messages.front(), expected);
{
dynamic messageInit = dynamic::object("method", "init")(
"params", dynamic::object("plugin", "Test"));
auto responder = std::make_unique<FlipperResponderMock>();
socket->onMessageReceived(messageInit, getResponder());
EXPECT_TRUE(pluginConnected);
}
{
dynamic messageDeinit = dynamic::object("method", "deinit")(
"params", dynamic::object("plugin", "Test"));
auto responder = std::make_unique<FlipperResponderMock>();
socket->onMessageReceived(messageDeinit, getResponder());
EXPECT_FALSE(pluginConnected);
}
{
dynamic messageReinit = dynamic::object("method", "init")(
"params", dynamic::object("plugin", "Test"));
auto responder = std::make_unique<FlipperResponderMock>();
socket->onMessageReceived(messageReinit, getResponder());
EXPECT_TRUE(pluginConnected);
}
client->stop();
EXPECT_FALSE(pluginConnected);
}
TEST_F(FlipperClientTest, testRemovePluginWhenConnected) {
bool pluginConnected = false;
const auto connectionCallback = [&](std::shared_ptr<FlipperConnection> conn) {
pluginConnected = true;
};
const auto disconnectionCallback = [&]() { pluginConnected = false; };
auto plugin = std::make_shared<FlipperPluginMock>(
"Test", connectionCallback, disconnectionCallback);
client->addPlugin(plugin);
client->start();
client->removePlugin(plugin);
EXPECT_FALSE(pluginConnected);
dynamic expected = dynamic::object("method", "refreshPlugins");
EXPECT_EQ(socket->messages.back(), expected);
}
TEST_F(FlipperClientTest, testUnhandleableMethod) {
auto plugin = std::make_shared<FlipperPluginMock>("Test");
client->addPlugin(plugin);
{
dynamic messageInit = dynamic::object("method", "init")(
"params", dynamic::object("plugin", "Test"));
auto responder = std::make_unique<FlipperResponderMock>();
socket->onMessageReceived(messageInit, getResponder());
}
{
dynamic messageExecute = dynamic::object("id", 1)("method", "unexpected");
auto responder = std::make_unique<FlipperResponderMock>();
socket->onMessageReceived(messageExecute, getResponder());
}
dynamic expected =
dynamic::object("message", "Received unknown method: unexpected");
EXPECT_EQ(failures[0], expected);
EXPECT_EQ(successes.size(), 0);
}
TEST_F(FlipperClientTest, testExecute) {
client->start();
const auto connectionCallback = [](std::shared_ptr<FlipperConnection> conn) {
const auto receiver = [](const dynamic& params,
std::shared_ptr<FlipperResponder> responder) {
dynamic payload = dynamic::object("message", "yes_i_hear_u");
responder->success(payload);
};
conn->receive("plugin_can_u_hear_me", receiver);
};
auto plugin = std::make_shared<FlipperPluginMock>("Test", connectionCallback);
client->addPlugin(plugin);
{
dynamic messageInit = dynamic::object("method", "init")(
"params", dynamic::object("plugin", "Test"));
auto responder = std::make_unique<FlipperResponderMock>();
socket->onMessageReceived(messageInit, getResponder());
}
{
dynamic messageUnexpected = dynamic::object("id", 1)("method", "execute")(
"params",
dynamic::object("api", "Test")("method", "plugin_can_u_hear_me"));
auto responder = std::make_shared<FlipperResponderMock>();
socket->callbacks->onMessageReceived(messageUnexpected, getResponder());
}
dynamic expected = dynamic::object("message", "yes_i_hear_u");
EXPECT_EQ(successes[0], expected);
EXPECT_EQ(failures.size(), 0);
}
TEST_F(FlipperClientTest, testExecuteWithParams) {
const auto connectionCallback = [&](std::shared_ptr<FlipperConnection> conn) {
const auto receiver = [](const dynamic& params,
std::shared_ptr<FlipperResponder> responder) {
const auto& first = params["first"].asString();
const auto& second = params["second"].asString();
std::map<std::string, std::string> m{{"dog", "woof"}, {"cat", "meow"}};
dynamic payload = dynamic::object(first, m[first])(second, m[second]);
responder->success(payload);
};
conn->receive("animal_sounds", receiver);
};
auto plugin = std::make_shared<FlipperPluginMock>("Test", connectionCallback);
client->addPlugin(plugin);
{
dynamic messageInit = dynamic::object("method", "init")(
"params", dynamic::object("plugin", "Test"));
auto responder = std::make_unique<FlipperResponderMock>();
socket->onMessageReceived(messageInit, getResponder());
}
{
dynamic messageExecute = dynamic::object("id", 1)("method", "execute")(
"params",
dynamic::object("api", "Test")("method", "animal_sounds")(
"params", dynamic::object("first", "dog")("second", "cat")));
auto responder = std::make_unique<FlipperResponderMock>();
socket->onMessageReceived(messageExecute, getResponder());
}
dynamic expected = dynamic::object("dog", "woof")("cat", "meow");
EXPECT_EQ(successes[0], expected);
EXPECT_EQ(failures.size(), 0);
}
TEST_F(FlipperClientTest, testExceptionUnknownPlugin) {
client->start();
dynamic messageInit = dynamic::object("method", "init")(
"params", dynamic::object("plugin", "Unknown"));
auto responder = std::make_unique<FlipperResponderMock>();
socket->onMessageReceived(messageInit, getResponder());
auto failure = failures[0];
EXPECT_EQ(failure["message"], "Plugin Unknown not found for method init");
EXPECT_EQ(failure["name"], "PluginNotFound");
}
TEST_F(FlipperClientTest, testExceptionUnknownApi) {
client->start();
dynamic messageInit = dynamic::object("method", "execute")(
"params", dynamic::object("api", "Unknown"));
auto responder = std::make_unique<FlipperResponderMock>();
socket->onMessageReceived(messageInit, getResponder());
auto failure = failures[0];
EXPECT_EQ(
failure["message"], "Connection Unknown not found for method execute");
EXPECT_EQ(failure["name"], "ConnectionNotFound");
}
TEST_F(FlipperClientTest, testBackgroundPluginActivated) {
dynamic messageInit = dynamic::object("method", "init")(
"params", dynamic::object("plugin", "Test"));
dynamic messageDeinit = dynamic::object("method", "deinit")(
"params", dynamic::object("plugin", "Test"));
bool pluginConnected = false;
const auto connectionCallback = [&](std::shared_ptr<FlipperConnection> conn) {
pluginConnected = true;
};
const auto disconnectionCallback = [&]() { pluginConnected = false; };
auto plugin = std::make_shared<FlipperPluginMock>(
"Test", connectionCallback, disconnectionCallback, true);
client->addPlugin(plugin);
client->start();
EXPECT_FALSE(pluginConnected);
{
auto responder = std::make_unique<FlipperResponderMock>();
socket->onMessageReceived(messageInit, getResponder());
EXPECT_TRUE(pluginConnected);
}
{
auto responder = std::make_unique<FlipperResponderMock>();
socket->onMessageReceived(messageDeinit, getResponder());
EXPECT_FALSE(pluginConnected);
}
{
auto responder = std::make_unique<FlipperResponderMock>();
socket->onMessageReceived(messageInit, getResponder());
EXPECT_TRUE(pluginConnected);
}
client->stop();
EXPECT_FALSE(pluginConnected);
}
TEST_F(FlipperClientTest, testNonBackgroundPluginNotActivated) {
bool pluginConnected = false;
const auto connectionCallback = [&](std::shared_ptr<FlipperConnection> conn) {
pluginConnected = true;
};
const auto disconnectionCallback = [&]() { pluginConnected = false; };
auto plugin = std::make_shared<FlipperPluginMock>(
"Test", connectionCallback, disconnectionCallback, false);
client->addPlugin(plugin);
client->start();
EXPECT_FALSE(pluginConnected);
client->stop();
EXPECT_FALSE(pluginConnected);
}
TEST_F(FlipperClientTest, testCrashInDidConnectDisConnectIsSuppressed) {
const auto connectionCallback = [&](std::shared_ptr<FlipperConnection> conn) {
throw std::runtime_error("Runtime Error in test");
};
const auto disconnectionCallback = [&]() {
throw std::runtime_error("Runtime Error in test");
};
auto plugin = std::make_shared<FlipperPluginMock>(
"Test", connectionCallback, disconnectionCallback, true);
client->addPlugin(plugin);
EXPECT_NO_FATAL_FAILURE(client->start());
EXPECT_NO_FATAL_FAILURE(client->stop());
}
TEST_F(
FlipperClientTest,
testNonStandardCrashInDidConnectDisConnectIsSuppressed) {
const auto connectionCallback = [&](std::shared_ptr<FlipperConnection> conn) {
throw "Non standard exception";
};
const auto disconnectionCallback = [&]() { throw "Non standard exception"; };
auto plugin = std::make_shared<FlipperPluginMock>(
"Test", connectionCallback, disconnectionCallback, true);
client->addPlugin(plugin);
EXPECT_NO_FATAL_FAILURE(client->start());
EXPECT_NO_FATAL_FAILURE(client->stop());
}
} // namespace test
} // namespace flipper
} // namespace facebook