Summary: `/*` is the standard throughout open source code. For example, Firefox uses single /*: https://hg.mozilla.org/mozilla-central/file/21d22b2f541258d3d1cf96c7ba5ad73e96e616b5/gfx/ipc/CompositorWidgetVsyncObserver.cpp#l3 In addition, Rust considers `/**` to be a doc comment (similar to Javadoc) and having such a comment at the beginning of the file causes `rustc` to barf. Note that some JavaScript tooling requires `/**`. This is OK since JavaScript files were not covered by the linter in the first place, but it would be good to have that tooling fixed too. Reviewed By: zertosh Differential Revision: D15640366 fbshipit-source-id: b4ed4599071516364d6109720750d6a43304c089
68 lines
2.2 KiB
C++
68 lines
2.2 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the LICENSE
|
|
* file in the root directory of this source tree.
|
|
*/
|
|
#include <Flipper/FlipperRSocketResponder.h>
|
|
#include <Flipper/Log.h>
|
|
#include <FlipperTestLib/FlipperConnectionManagerMock.h>
|
|
#include <folly/json.h>
|
|
#include <gtest/gtest.h>
|
|
|
|
namespace facebook {
|
|
namespace flipper {
|
|
namespace test {
|
|
|
|
using folly::dynamic;
|
|
|
|
class Callbacks
|
|
: public facebook::flipper::FlipperConnectionManager::Callbacks {
|
|
public:
|
|
void onConnected() {}
|
|
void onDisconnected() {}
|
|
void onMessageReceived(
|
|
const folly::dynamic& message,
|
|
std::unique_ptr<FlipperResponder> responder) {
|
|
message_ = message;
|
|
responder_ = std::move(responder);
|
|
}
|
|
folly::dynamic message_;
|
|
std::unique_ptr<FlipperResponder> responder_;
|
|
};
|
|
|
|
TEST(FlipperRSocketResponderTests, testFireAndForgetWithoutIdParam) {
|
|
auto socket = facebook::flipper::test::FlipperConnectionManagerMock();
|
|
auto callbacks = new Callbacks();
|
|
socket.setCallbacks(callbacks);
|
|
folly::EventBase* eb = new folly::EventBase();
|
|
auto responder = facebook::flipper::FlipperRSocketResponder(&socket, eb);
|
|
dynamic d = dynamic::object("my", "message");
|
|
auto json = folly::toJson(d);
|
|
|
|
responder.handleFireAndForget(rsocket::Payload(json), rsocket::StreamId(1));
|
|
EXPECT_EQ(socket.messagesReceived.size(), 1);
|
|
EXPECT_EQ(socket.messagesReceived[0]["my"], "message");
|
|
EXPECT_EQ(socket.respondersReceived, 0);
|
|
}
|
|
|
|
TEST(FlipperRSocketResponderTests, testFireAndForgetWithIdParam) {
|
|
auto socket = facebook::flipper::test::FlipperConnectionManagerMock();
|
|
auto callbacks = new Callbacks();
|
|
socket.setCallbacks(callbacks);
|
|
folly::EventBase* eb = new folly::EventBase();
|
|
auto responder = facebook::flipper::FlipperRSocketResponder(&socket, eb);
|
|
dynamic d = dynamic::object("my", "message")("id", 7);
|
|
auto json = folly::toJson(d);
|
|
|
|
responder.handleFireAndForget(rsocket::Payload(json), rsocket::StreamId(1));
|
|
EXPECT_EQ(socket.messagesReceived.size(), 1);
|
|
EXPECT_EQ(socket.messagesReceived[0]["my"], "message");
|
|
EXPECT_EQ(socket.messagesReceived[0]["id"], 7);
|
|
EXPECT_EQ(socket.respondersReceived, 1);
|
|
}
|
|
|
|
} // namespace test
|
|
} // namespace flipper
|
|
} // namespace facebook
|