Summary: This diff enables optional [Fast Refresh](https://reactnative.dev/docs/fast-refresh) for Flipper in dev mode. It can be opted-in using additional argument "--fast-refresh": `yarn start --fast-refresh`. I've copy-pasted the most part of implementation from React Native with some minor changes. I made this optional for now as it works not ideally. In most cases which I checked it works fine, however for some files it falls back to full refresh (e.g. when `desktop/plugins/network/index.tsx` changed) and sometimes doesn't refresh content even after change detected and re-compiled (e.g. when `src/ui/components/searchable/Searchable.tsx` is changed, Network plugin which is dependent on it is not refreshed automatically). State from redux is restored after fast refresh, but local state in class-based components is cleared. For function-based components local state is also stored, so it's an additional point to make plugins components functional :) Also, for now there is no UI for Fast Refresh (loading indicator etc), information is just logged to console. Changelog: Experimental support for Fast Refresh in dev mode can be enabled by `yarn start --fast-refresh`. Reviewed By: jknoxville Differential Revision: D20993073 fbshipit-source-id: 65632788df105a85fac0b924b7808120900b349e
295 lines
9.0 KiB
JavaScript
295 lines
9.0 KiB
JavaScript
/**
|
||
* Copyright (c) Facebook, Inc. and its affiliates.
|
||
*
|
||
* This source code is licensed under the MIT license found in the
|
||
* LICENSE file in the root directory of this source tree.
|
||
*
|
||
* @format
|
||
*/
|
||
|
||
/**
|
||
* * * * * * * ** * * * * * * * * * * * * * * * * * ** * * * * * * * * * * * * * * * * * ** * * * * * * * * *
|
||
* This implementation of HMR Client is based on React Native implementation with some code commented out: *
|
||
* https://github.com/facebook/react-native/blob/master/Libraries/Utilities/HMRClient.js *
|
||
* * * * * * * ** * * * * * * * * * * * * * * * * * ** * * * * * * * * * * * * * * * * * ** * * * * * * * * *
|
||
*/
|
||
|
||
// // const DevSettings = require('./DevSettings');
|
||
import invariant from 'invariant';
|
||
import {default as MetroHMRClient} from 'metro/src/lib/bundle-modules/HMRClient';
|
||
// // const Platform = require('./Platform');
|
||
import prettyFormat from 'pretty-format';
|
||
|
||
const pendingEntryPoints = [];
|
||
let hmrClient = null;
|
||
let hmrUnavailableReason = null;
|
||
let currentCompileErrorMessage = null;
|
||
let didConnect = false;
|
||
const pendingLogs = [];
|
||
|
||
/**
|
||
* HMR Client that receives from the server HMR updates and propagates them
|
||
* runtime to reflects those changes.
|
||
*/
|
||
const HMRClient = {
|
||
enable() {
|
||
if (hmrUnavailableReason !== null) {
|
||
// If HMR became unavailable while you weren't using it,
|
||
// explain why when you try to turn it on.
|
||
// This is an error (and not a warning) because it is shown
|
||
// in response to a direct user action.
|
||
throw new Error(hmrUnavailableReason);
|
||
}
|
||
|
||
invariant(hmrClient, 'Expected HMRClient.setup() call at startup.');
|
||
//// const LoadingView = require('./LoadingView');
|
||
|
||
// We use this for internal logging only.
|
||
// It doesn't affect the logic.
|
||
hmrClient.send(JSON.stringify({type: 'log-opt-in'}));
|
||
|
||
// When toggling Fast Refresh on, we might already have some stashed updates.
|
||
// Since they'll get applied now, we'll show a banner.
|
||
const hasUpdates = hmrClient.hasPendingUpdates();
|
||
|
||
if (hasUpdates) {
|
||
//// LoadingView.showMessage('Refreshing...', 'refresh');
|
||
console.log('Loading start: Refreshing...');
|
||
}
|
||
try {
|
||
hmrClient.enable();
|
||
} finally {
|
||
if (hasUpdates) {
|
||
//// LoadingView.hide();
|
||
console.log('Loading end');
|
||
}
|
||
}
|
||
|
||
// There could be a compile error while Fast Refresh was off,
|
||
// but we ignored it at the time. Show it now.
|
||
showCompileError();
|
||
},
|
||
|
||
disable() {
|
||
invariant(hmrClient, 'Expected HMRClient.setup() call at startup.');
|
||
hmrClient.disable();
|
||
},
|
||
|
||
registerBundle(requestUrl) {
|
||
invariant(hmrClient, 'Expected HMRClient.setup() call at startup.');
|
||
pendingEntryPoints.push(requestUrl);
|
||
registerBundleEntryPoints(hmrClient);
|
||
},
|
||
|
||
log(level, data) {
|
||
if (!hmrClient) {
|
||
// Catch a reasonable number of early logs
|
||
// in case hmrClient gets initialized later.
|
||
pendingLogs.push([level, data]);
|
||
if (pendingLogs.length > 100) {
|
||
pendingLogs.shift();
|
||
}
|
||
return;
|
||
}
|
||
try {
|
||
hmrClient.send(
|
||
JSON.stringify({
|
||
type: 'log',
|
||
level,
|
||
data: data.map((item) =>
|
||
typeof item === 'string'
|
||
? item
|
||
: prettyFormat(item, {
|
||
escapeString: true,
|
||
highlight: true,
|
||
maxDepth: 3,
|
||
min: true,
|
||
plugins: [prettyFormat.plugins.ReactElement],
|
||
}),
|
||
),
|
||
}),
|
||
);
|
||
} catch (error) {
|
||
// If sending logs causes any failures we want to silently ignore them
|
||
// to ensure we do not cause infinite-logging loops.
|
||
}
|
||
},
|
||
|
||
// Called once by the bridge on startup, even if Fast Refresh is off.
|
||
// It creates the HMR client but doesn't actually set up the socket yet.
|
||
setup(platform, bundleEntry, host, port, isEnabled) {
|
||
invariant(platform, 'Missing required parameter `platform`');
|
||
invariant(bundleEntry, 'Missing required parameter `bundleEntry`');
|
||
invariant(host, 'Missing required parameter `host`');
|
||
invariant(!hmrClient, 'Cannot initialize hmrClient twice');
|
||
|
||
//// const LoadingView = require('./LoadingView');
|
||
|
||
const wsHost = port !== null && port !== '' ? `${host}:${port}` : host;
|
||
const client = new MetroHMRClient(`ws://${wsHost}/hot`);
|
||
hmrClient = client;
|
||
|
||
pendingEntryPoints.push(
|
||
`ws://${wsHost}/hot?bundleEntry=${bundleEntry}&platform=${platform}`,
|
||
);
|
||
|
||
client.on('connection-error', (e) => {
|
||
let error = `Cannot connect to the Metro server.
|
||
Try the following to fix the issue:
|
||
- Ensure that the Metro server is running and available on the same network`;
|
||
|
||
error += `
|
||
- Ensure that your device/emulator is connected to your machine and has USB debugging enabled - run 'adb devices' to see a list of connected devices
|
||
- If you're on a physical device connected to the same machine, run 'adb reverse tcp:8081 tcp:8081' to forward requests from your device
|
||
- If your device is on the same Wi-Fi network, set 'Debug server host & port for device' in 'Dev settings' to your machine's IP address and the port of the local dev server - e.g. 10.0.1.1:8081`;
|
||
|
||
error += `
|
||
URL: ${host}:${port}
|
||
Error: ${e.message}`;
|
||
|
||
setHMRUnavailableReason(error);
|
||
});
|
||
|
||
client.on('update-start', ({isInitialUpdate}) => {
|
||
currentCompileErrorMessage = null;
|
||
didConnect = true;
|
||
|
||
if (client.isEnabled() && !isInitialUpdate) {
|
||
//// LoadingView.showMessage('Refreshing...', 'refresh');
|
||
console.log('Loading start: Refreshing...');
|
||
}
|
||
});
|
||
|
||
client.on('update', ({isInitialUpdate}) => {
|
||
if (client.isEnabled() && !isInitialUpdate) {
|
||
dismissRedbox();
|
||
//// LogBoxData.clear();
|
||
}
|
||
});
|
||
|
||
client.on('update-done', () => {
|
||
//// LoadingView.hide();
|
||
console.log('Loading end');
|
||
});
|
||
|
||
client.on('error', (data) => {
|
||
//// LoadingView.hide();
|
||
console.log('Loading end');
|
||
|
||
if (data.type === 'GraphNotFoundError') {
|
||
client.close();
|
||
setHMRUnavailableReason(
|
||
'The Metro server has restarted since the last edit. Reload to reconnect.',
|
||
);
|
||
} else if (data.type === 'RevisionNotFoundError') {
|
||
client.close();
|
||
setHMRUnavailableReason(
|
||
'The Metro server and the client are out of sync. Reload to reconnect.',
|
||
);
|
||
} else {
|
||
currentCompileErrorMessage = `${data.type} ${data.message}`;
|
||
if (client.isEnabled()) {
|
||
showCompileError();
|
||
}
|
||
}
|
||
});
|
||
|
||
client.on('close', (data) => {
|
||
//// LoadingView.hide();
|
||
console.log('Loading end');
|
||
setHMRUnavailableReason('Disconnected from the Metro server.');
|
||
});
|
||
|
||
if (isEnabled) {
|
||
HMRClient.enable();
|
||
} else {
|
||
HMRClient.disable();
|
||
}
|
||
|
||
registerBundleEntryPoints(hmrClient);
|
||
flushEarlyLogs(hmrClient);
|
||
},
|
||
};
|
||
|
||
function setHMRUnavailableReason(reason) {
|
||
invariant(hmrClient, 'Expected HMRClient.setup() call at startup.');
|
||
if (hmrUnavailableReason !== null) {
|
||
// Don't show more than one warning.
|
||
return;
|
||
}
|
||
hmrUnavailableReason = reason;
|
||
|
||
// We only want to show a warning if Fast Refresh is on *and* if we ever
|
||
// previously managed to connect successfully. We don't want to show
|
||
// the warning to native engineers who use cached bundles without Metro.
|
||
if (hmrClient.isEnabled() && didConnect) {
|
||
console.warn(reason);
|
||
// (Not using the `warning` module to prevent a Buck cycle.)
|
||
}
|
||
}
|
||
|
||
function registerBundleEntryPoints(client) {
|
||
if (hmrUnavailableReason) {
|
||
// // DevSettings.reload('Bundle Splitting – Metro disconnected');
|
||
console.log('Bundle Spliiting - Metro disconnected');
|
||
return;
|
||
}
|
||
|
||
if (pendingEntryPoints.length > 0) {
|
||
client.send(
|
||
JSON.stringify({
|
||
type: 'register-entrypoints',
|
||
entryPoints: pendingEntryPoints,
|
||
}),
|
||
);
|
||
pendingEntryPoints.length = 0;
|
||
}
|
||
}
|
||
|
||
function flushEarlyLogs(client) {
|
||
try {
|
||
pendingLogs.forEach(([level, data]) => {
|
||
HMRClient.log(level, data);
|
||
});
|
||
} finally {
|
||
pendingLogs.length = 0;
|
||
}
|
||
}
|
||
|
||
function dismissRedbox() {
|
||
// // if (
|
||
// // Platform.OS === 'ios' &&
|
||
// // NativeRedBox != null &&
|
||
// // NativeRedBox.dismiss != null
|
||
// // ) {
|
||
// // NativeRedBox.dismiss();
|
||
// // } else {
|
||
// // const NativeExceptionsManager = require('../Core/NativeExceptionsManager')
|
||
// // .default;
|
||
// // NativeExceptionsManager &&
|
||
// // NativeExceptionsManager.dismissRedbox &&
|
||
// // NativeExceptionsManager.dismissRedbox();
|
||
// // }
|
||
}
|
||
|
||
function showCompileError() {
|
||
if (currentCompileErrorMessage === null) {
|
||
return;
|
||
}
|
||
|
||
// Even if there is already a redbox, syntax errors are more important.
|
||
// Otherwise you risk seeing a stale runtime error while a syntax error is more recent.
|
||
dismissRedbox();
|
||
|
||
const message = currentCompileErrorMessage;
|
||
currentCompileErrorMessage = null;
|
||
|
||
const error = new Error(message);
|
||
// Symbolicating compile errors is wasted effort
|
||
// because the stack trace is meaningless:
|
||
error.preventSymbolication = true;
|
||
throw error;
|
||
}
|
||
|
||
export default HMRClient;
|