e831743132
Summary: Taking another stab at adding some lint rules to make it harder to shoot yourself in the foot. Hopefully nothing too controversial. Preferring spread and rest should lead is more readable and there's no downside when using ES6. The "useless" rules are just things like renaming imports to the original name which should only happen during refactors. Reviewed By: jknoxville Differential Revision: D16180453 fbshipit-source-id: 1cf6851b7726c0aee953ec7cf7dd6fa0aca32253
55 lines
1.8 KiB
JavaScript
55 lines
1.8 KiB
JavaScript
/**
|
|
* Copyright 2018-present Facebook.
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
* @format
|
|
*/
|
|
|
|
const fbjs = require('eslint-config-fbjs');
|
|
|
|
// enforces copyright header and @format directive to be present in every file
|
|
const pattern = /^\*\n \* Copyright 20\d{2}-present Facebook\.\n \* This source code is licensed under the MIT license found in the\n \* LICENSE file in the root directory of this source tree\.\n \* @format\n./;
|
|
|
|
module.exports = {
|
|
parser: 'babel-eslint',
|
|
extends: 'fbjs',
|
|
plugins: [...fbjs.plugins, 'header', 'prettier'],
|
|
rules: {
|
|
// disable rules from eslint-config-fbjs
|
|
'react/react-in-jsx-scope': 0, // not needed with our metro implementation
|
|
'no-new': 0, // new keyword needed e.g. new Notification
|
|
'no-catch-shadow': 0, // only relevant for IE8 and below
|
|
'no-bitwise': 0, // bitwise operations needed in some places
|
|
'consistent-return': 0,
|
|
'no-var': 2,
|
|
'prefer-const': [2, {destructuring: 'all'}],
|
|
'prefer-spread': 1,
|
|
'prefer-rest-params': 1,
|
|
'max-len': 0, // lets prettier take care of this
|
|
indent: 0, // lets prettier take care of this
|
|
'no-console': 0, // we're setting window.console in App.js
|
|
'no-multi-spaces': 2,
|
|
'prefer-promise-reject-errors': 1,
|
|
'no-extra-boolean-cast': 2,
|
|
'no-extra-semi': 2,
|
|
'no-unsafe-negation': 2,
|
|
'no-useless-computed-key': 2,
|
|
'no-useless-rename': 2,
|
|
|
|
// additional rules for this project
|
|
'header/header': [2, 'block', {pattern}],
|
|
'prettier/prettier': [
|
|
2,
|
|
{
|
|
requirePragma: true,
|
|
singleQuote: true,
|
|
trailingComma: 'all',
|
|
bracketSpacing: false,
|
|
jsxBracketSameLine: true,
|
|
parser: 'flow',
|
|
},
|
|
],
|
|
'flowtype/object-type-delimiter': [0],
|
|
},
|
|
};
|