98f56a30ed
Summary:
As explained in this [Issue](https://github.com/facebook/flipper/issues/1919) when running checks to see if Jetifier is needed to compile any given app using Flipper, it complain due to the dependency on `com.parse.bolts:bolts-applinks:1.4.0`.
```
Scanning com.parse.bolts:bolts-applinks:1.4.0
Absoulute path: /....../bolts-applinks-1.4.0.jar
Graphs to this dependency:
+---com.facebook.flipper:flipper:0.74.0
+---com.parse.bolts:bolts-applinks:1.4.0
> Task :canISayByeByeJetifier FAILED
```
Bolts has already fixed the AndroidX migration in version `1.5.0` but it has never been published ([Issue](https://github.com/BoltsFramework/Bolts-Android/issues/157))
After checking the code i realized flipper is only using `bolts-tasks` in `FrescoFlipperPlugin` ([code](7bd4f80c25/android/plugins/fresco/src/main/java/com/facebook/flipper/plugins/fresco/FrescoFlipperPlugin.java (L14))).
`bolts-applinks` depends on `bolts-tasks` but **not the other way around**, so we can safely remove this dependency.
## Changelog
- Removed dependency on bolts-applinks not in use
Pull Request resolved: https://github.com/facebook/flipper/pull/2580
Test Plan:
### Tests
- [ ] Run unit tests `./gradlew :android:test` and make sure they pass
### Smoke test `fresco-plugin`
- [ ] Make sure `android/sample` compiles and runs
- In the Flipper desktop app enable `Images` plugin
- In the Android sample app tap on `Load Fresco Image`
- [ ] Verify in desktop app that the image shows correctly and the plugin works
Reviewed By: muraziz
Differential Revision: D29849669
Pulled By: jknoxville
fbshipit-source-id: 0cec730de3b94272985fec4a432ca244822f336f
108 lines
4.7 KiB
Groovy
108 lines
4.7 KiB
Groovy
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
buildscript {
|
|
repositories {
|
|
google()
|
|
mavenCentral()
|
|
}
|
|
dependencies {
|
|
classpath 'com.android.tools.build:gradle:4.2.1'
|
|
classpath 'com.vanniktech:gradle-maven-publish-plugin:0.16.0'
|
|
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$KOTLIN_VERSION"
|
|
classpath "org.jetbrains.dokka:dokka-gradle-plugin:1.5.0"
|
|
}
|
|
}
|
|
|
|
plugins {
|
|
id 'de.undercouch.download' version '4.1.1'
|
|
id 'com.github.ben-manes.versions' version '0.39.0'
|
|
}
|
|
|
|
ext.isSnapshot = { VERSION_NAME.endsWith('-SNAPSHOT') }
|
|
ext.isRelease = { ['uploadArchives', 'bintrayUpload'].any { gradle.startParameter.taskNames.contains(it) } }
|
|
|
|
subprojects {
|
|
repositories {
|
|
google()
|
|
mavenLocal()
|
|
mavenCentral()
|
|
jcenter()
|
|
|
|
if (isSnapshot()) {
|
|
maven { url 'https://oss.sonatype.org/content/repositories/snapshots/' }
|
|
}
|
|
}
|
|
|
|
// We don't build Javadoc at this time.
|
|
tasks.withType(Javadoc).all {
|
|
enabled = false
|
|
}
|
|
}
|
|
|
|
ext {
|
|
minSdkVersion = 15
|
|
targetSdkVersion = 30
|
|
compileSdkVersion = 30
|
|
buildToolsVersion = '30.0.2'
|
|
ndkVersion = '21.3.6528147'
|
|
}
|
|
|
|
ext.deps = [
|
|
// Android support
|
|
supportAnnotations : "androidx.annotation:annotation:$ANDROIDX_VERSION",
|
|
supportAppCompat : "androidx.appcompat:appcompat:$ANDROIDX_VERSION",
|
|
supportCoreUi : "androidx.legacy:legacy-support-core-ui:$ANDROIDX_VERSION",
|
|
supportRecyclerView: "androidx.recyclerview:recyclerview:$ANDROIDX_VERSION",
|
|
supportConstraintLayout: "androidx.constraintlayout:constraintlayout:2.0.4",
|
|
supportSqlite : "androidx.sqlite:sqlite-framework:2.1.0",
|
|
supportEspresso : 'androidx.test.espresso:espresso-core:3.3.0',
|
|
supportEspressoIntents : 'androidx.test.espresso:espresso-intents:3.3.0',
|
|
supportTestRunner : 'androidx.test:runner:1.3.0',
|
|
// Arch
|
|
archPaging : 'android.arch.paging:runtime:1.0.1',
|
|
// First-party
|
|
soloader : 'com.facebook.soloader:soloader:0.10.1',
|
|
fbjni : 'com.facebook.fbjni:fbjni:0.2.2',
|
|
screenshot : 'com.facebook.testing.screenshot:core:0.14.0',
|
|
boltsTasks : 'com.parse.bolts:bolts-tasks:1.4.0',
|
|
// Annotations
|
|
jsr305 : 'com.google.code.findbugs:jsr305:3.0.2',
|
|
inferAnnotations : 'com.facebook.infer.annotation:infer-annotation:0.18.0',
|
|
proguardAnnotations: 'com.facebook.yoga:proguard-annotations:1.19.0',
|
|
// Litho
|
|
lithoAnnotations : "com.facebook.litho:litho-annotations:$LITHO_VERSION",
|
|
lithoCore : "com.facebook.litho:litho-core:$LITHO_VERSION",
|
|
lithoEditorCore : "com.facebook.litho:litho-editor-core:$LITHO_VERSION",
|
|
lithoEditorFlipper : "com.facebook.litho:litho-editor-flipper:$LITHO_VERSION",
|
|
lithoSectionsAnnotations: "com.facebook.litho:litho-sections-annotations:$LITHO_VERSION",
|
|
lithoSectionsDebug : "com.facebook.litho:litho-sections-debug:$LITHO_VERSION",
|
|
lithoSectionsCore : "com.facebook.litho:litho-sections-core:$LITHO_VERSION",
|
|
lithoSectionsWidget : "com.facebook.litho:litho-sections-widget:$LITHO_VERSION",
|
|
lithoWidget : "com.facebook.litho:litho-widget:$LITHO_VERSION",
|
|
lithoProcessor : "com.facebook.litho:litho-processor:$LITHO_VERSION",
|
|
lithoSectionsProcessor: "com.facebook.litho:litho-sections-processor:$LITHO_VERSION",
|
|
lithoFresco : "com.facebook.litho:litho-fresco:$LITHO_VERSION",
|
|
lithoTesting : "com.facebook.litho:litho-testing:$LITHO_VERSION",
|
|
// Debugging and testing
|
|
guava : 'com.google.guava:guava:23.0',
|
|
robolectric : 'org.robolectric:robolectric:4.5.1',
|
|
junit : 'junit:junit:4.13.2',
|
|
hamcrest : 'org.hamcrest:hamcrest-library:2.2',
|
|
mockito : 'org.mockito:mockito-core:3.11.2',
|
|
okhttp3 : 'com.squareup.okhttp3:okhttp:4.9.1',
|
|
leakcanary : 'com.squareup.leakcanary:leakcanary-android:1.6.3',
|
|
leakcanary2 : 'com.squareup.leakcanary:leakcanary-android:2.6',
|
|
protobuf : 'com.google.protobuf:protobuf-java:3.17.3',
|
|
testCore : 'androidx.test:core:1.3.0',
|
|
testRules : 'androidx.test:rules:1.3.0',
|
|
// Plugin dependencies
|
|
frescoFlipper : 'com.facebook.fresco:flipper:2.5.0',
|
|
frescoStetho : 'com.facebook.fresco:stetho:2.5.0',
|
|
fresco : 'com.facebook.fresco:fresco:2.5.0'
|
|
]
|