Summary: For the visualiser we use the same trick as with the hover state. We subscribe to selection changes and only render if the prev or new state concerns us. For the tree we change from object identity to the node id + and indent guide are added to the memoisation equal check. Depending on teh change this tree memoisation can vary in effectiveness. If you go from nothing selecting to selecting the top element nothing is memoised since react needs to render every element to draw the indent guide. If you have somethign selected and select a nearby element the memoisation works well. There are ways to improve this more down the road changelog: UIDebugger improve performance of selecting nodes Reviewed By: lblasa Differential Revision: D43305979 fbshipit-source-id: 5d90e806ed7b6a8401e9968be398d4a67ed0c294
85 lines
2.4 KiB
TypeScript
85 lines
2.4 KiB
TypeScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
*/
|
|
|
|
import React from 'react';
|
|
// eslint-disable-next-line rulesdir/no-restricted-imports-clone
|
|
import {Glyph} from 'flipper';
|
|
import {Layout, Tab, Tabs, theme, usePlugin, useValue} from 'flipper-plugin';
|
|
import {Id, Metadata, MetadataId, UINode} from '../../types';
|
|
|
|
import {IdentityInspector} from './inspector/IdentityInspector';
|
|
import {AttributesInspector} from './inspector/AttributesInspector';
|
|
import {Tooltip} from 'antd';
|
|
import {NoData} from './inspector/NoData';
|
|
import {plugin} from '../../index';
|
|
|
|
type Props = {
|
|
nodes: Map<Id, UINode>;
|
|
metadata: Map<MetadataId, Metadata>;
|
|
};
|
|
|
|
export const Inspector: React.FC<Props> = ({nodes, metadata}) => {
|
|
const instance = usePlugin(plugin);
|
|
const selectedNodeId = useValue(instance.uiState.selectedNode);
|
|
|
|
const selectedNode = nodes.get(selectedNodeId!!);
|
|
if (!selectedNode) {
|
|
return <NoData message="Please select a node to view its details" />;
|
|
}
|
|
return (
|
|
<Layout.Container gap pad>
|
|
<Tabs grow centered>
|
|
<Tab
|
|
tab={
|
|
<Tooltip title="Identity">
|
|
<Layout.Horizontal center>
|
|
<Glyph name="badge" size={16} color={theme.primaryColor} />
|
|
</Layout.Horizontal>
|
|
</Tooltip>
|
|
}>
|
|
<IdentityInspector node={selectedNode} />
|
|
</Tab>
|
|
|
|
<Tab
|
|
tab={
|
|
<Tooltip title="Attributes">
|
|
<Layout.Horizontal center>
|
|
<Glyph name="data-table" size={16} color={theme.primaryColor} />
|
|
</Layout.Horizontal>
|
|
</Tooltip>
|
|
}>
|
|
<AttributesInspector
|
|
mode="attribute"
|
|
node={selectedNode}
|
|
metadata={metadata}
|
|
/>
|
|
</Tab>
|
|
<Tab
|
|
tab={
|
|
<Tooltip title="Layout">
|
|
<Layout.Horizontal center>
|
|
<Glyph
|
|
name="square-ruler"
|
|
size={16}
|
|
color={theme.primaryColor}
|
|
/>
|
|
</Layout.Horizontal>
|
|
</Tooltip>
|
|
}>
|
|
<AttributesInspector
|
|
mode="layout"
|
|
node={selectedNode}
|
|
metadata={metadata}
|
|
/>
|
|
</Tab>
|
|
</Tabs>
|
|
</Layout.Container>
|
|
);
|
|
};
|