Files

Michel Weststrate d162bcc2a4 Fix sorting order of selection during exports

Summary:
See https://fb.workplace.com/100051336486185/videos/469885544533059/

I couldn't reproduce it myself, but it is reported that when copying logs, the order of the selection is not preserve. Diving into the example there is a block of rows (around the 1.09 timestamp) that appear 'too early' in the output.

In flipper we sort the selection before copying the data by row index. This is to make sure if the user has multiple selections, they appear in the order of the logs (including any applied sorting), rather than in the order of which the user selected them.

However, when sorting numbers, JavaScript by coerces them to strings first (wtf JS), so the issue can be prevented by explicitly providing a sort function. Proof: {F749329864}

Reviewed By: lblasa

Differential Revision: D37596975

fbshipit-source-id: 820e03350034e7af8148200a58a8c858b358acd8

2022-07-04 04:13:04 -07:00

src

Fix sorting order of selection during exports

2022-07-04 04:13:04 -07:00

package.json

Share uuid

2022-05-18 03:13:31 -07:00

README.md

Initialized flipper-plugin library

2020-07-01 09:12:35 -07:00

tsconfig.json

Migrate to React 18

2022-03-31 04:01:33 -07:00

README.md

flipper-plugin

flipper-plugin is the dependency used by all modern Flipper plugins (project "Tommy").

For background: https://fb.quip.com/YHOGAnaPqAVJ

flipper-plugin is to be used as dev and peer dependency of all Flipper plugins. It provides:

(TODO) Standard API's to interact with Flipper, such as the client connection.
(TODO) Standard components to organize the UI
(TODO) Testing utilities

API's provided by flipper-plugin are documented at fbflipper.com (TODO).

There should normally be no need to install flipper-plugin as dependency. Rather, plugins should be scaffolded using npx flipper-pkg init (TODO) as documented here