e44c7f4062
Summary: Fix IOS crash in Network Plugin due to incorrect processing of data URLs (https://github.com/facebook/flipper/issues/974) Fix https://github.com/facebook/flipper/issues/974 by skipping response processing in FlipperKitNetworkPlugin.mm if the response is not an instance of NSHTTPURLResponse, which data URLs are not. My assumption is that data URLs are not the ones Flipper Network Plugin users are interested in, given the type of information being extracted in the didObserveResponse method which are only present in NSHTTPURLReponse types. ## Changelog Fix IOS crash in Network Plugin due to unchecked casting of data URLs Pull Request resolved: https://github.com/facebook/flipper/pull/978 Test Plan: 1. `npx react-native init issue974 --version react-native@0.62.1` 2. `cd issue974/ios/Pods/FlipperKit/iOS/Plugins/` 3. `curl -L https://patch-diff.githubusercontent.com/raw/facebook/flipper/pull/978.patch | git apply -v -p3` 4. `cd ../../../../../` 5. `curl -L https://github.com/facebook/flipper/files/4434063/rn-data-uri-test.patch.txt | git apply -v react-native run-ios` 6. Verify that the app does not crash the IOS app with ``` Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSURLResponse allHeaderFields]: unrecognized selector sent to instance <memaddr>' ``` #### The React Native app patch used to verify the PR working and resolving the issue https://github.com/facebook/flipper/issues/974 [rn-data-uri-test.patch.txt](https://github.com/facebook/flipper/files/4434063/rn-data-uri-test.patch.txt) Reviewed By: mweststrate Differential Revision: D20861168 Pulled By: cekkaewnumchai fbshipit-source-id: bae960650ecc0efbb8ae4641aba4c62c74f06bf0