98f56a30ed
Summary:
As explained in this [Issue](https://github.com/facebook/flipper/issues/1919) when running checks to see if Jetifier is needed to compile any given app using Flipper, it complain due to the dependency on `com.parse.bolts:bolts-applinks:1.4.0`.
```
Scanning com.parse.bolts:bolts-applinks:1.4.0
Absoulute path: /....../bolts-applinks-1.4.0.jar
Graphs to this dependency:
+---com.facebook.flipper:flipper:0.74.0
+---com.parse.bolts:bolts-applinks:1.4.0
> Task :canISayByeByeJetifier FAILED
```
Bolts has already fixed the AndroidX migration in version `1.5.0` but it has never been published ([Issue](https://github.com/BoltsFramework/Bolts-Android/issues/157))
After checking the code i realized flipper is only using `bolts-tasks` in `FrescoFlipperPlugin` ([code](7bd4f80c25/android/plugins/fresco/src/main/java/com/facebook/flipper/plugins/fresco/FrescoFlipperPlugin.java (L14))).
`bolts-applinks` depends on `bolts-tasks` but **not the other way around**, so we can safely remove this dependency.
## Changelog
- Removed dependency on bolts-applinks not in use
Pull Request resolved: https://github.com/facebook/flipper/pull/2580
Test Plan:
### Tests
- [ ] Run unit tests `./gradlew :android:test` and make sure they pass
### Smoke test `fresco-plugin`
- [ ] Make sure `android/sample` compiles and runs
- In the Flipper desktop app enable `Images` plugin
- In the Android sample app tap on `Load Fresco Image`
- [ ] Verify in desktop app that the image shows correctly and the plugin works
Reviewed By: muraziz
Differential Revision: D29849669
Pulled By: jknoxville
fbshipit-source-id: 0cec730de3b94272985fec4a432ca244822f336f
35 lines
914 B
Groovy
35 lines
914 B
Groovy
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
apply plugin: 'com.android.library'
|
|
|
|
android {
|
|
compileSdkVersion rootProject.compileSdkVersion
|
|
buildToolsVersion rootProject.buildToolsVersion
|
|
|
|
defaultConfig {
|
|
minSdkVersion rootProject.minSdkVersion
|
|
targetSdkVersion rootProject.targetSdkVersion
|
|
}
|
|
|
|
dependencies {
|
|
implementation project(':android')
|
|
implementation deps.fresco
|
|
implementation deps.frescoFlipper
|
|
compileOnly deps.jsr305
|
|
|
|
api deps.boltsTasks
|
|
|
|
// Exclude the actual stetho dep as we only want some of the fresco APIs here
|
|
implementation(deps.frescoStetho) {
|
|
exclude group: 'com.facebook.stetho'
|
|
}
|
|
}
|
|
}
|
|
|
|
apply plugin: 'com.vanniktech.maven.publish'
|