9d34c90b9a
Summary: The date type for crash reports was updated in D29327501 (aff02b2ca1) from `Date` to `number`. Unset values were previously `null` but became `NaN` in this change. `NaN` is nonnull so the backup value of `Date.now()` was not getting triggered properly and leading to "Invalid Date" to show up in the UI.
Reviewed By: passy
Differential Revision: D31702757
fbshipit-source-id: da93b1f79eb633b2f49dcffbe680d56d47a23ea0
106 lines
2.5 KiB
TypeScript
106 lines
2.5 KiB
TypeScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
*/
|
|
|
|
import type {FSWatcher} from 'fs';
|
|
import {createState, DevicePluginClient} from 'flipper-plugin';
|
|
import {showCrashNotification} from './crash-utils';
|
|
import {addFileWatcherForiOSCrashLogs} from './ios-crash-utils';
|
|
import {startAndroidCrashWatcher} from './android-crash-utils';
|
|
|
|
export type Crash = {
|
|
notificationID: string;
|
|
callstack?: string;
|
|
reason: string;
|
|
name: string;
|
|
date: number;
|
|
};
|
|
|
|
export type CrashLog = {
|
|
callstack: string;
|
|
reason: string;
|
|
name: string;
|
|
date?: number;
|
|
};
|
|
|
|
export function devicePlugin(client: DevicePluginClient) {
|
|
let notificationID = -1;
|
|
let watcher: Promise<FSWatcher | undefined> | undefined = undefined;
|
|
|
|
const crashes = createState<Crash[]>([], {persist: 'crashes'});
|
|
const selectedCrash = createState<string | undefined>();
|
|
|
|
client.onDeepLink((crashId) => {
|
|
selectedCrash.set(crashId as string);
|
|
});
|
|
|
|
function reportCrash(payload: CrashLog) {
|
|
notificationID++;
|
|
|
|
const crash = {
|
|
notificationID: notificationID.toString(),
|
|
callstack: payload.callstack,
|
|
name: payload.name,
|
|
reason: payload.reason,
|
|
date: payload.date || Date.now(),
|
|
};
|
|
|
|
crashes.update((draft) => {
|
|
draft.push(crash);
|
|
});
|
|
|
|
showCrashNotification(client, crash);
|
|
}
|
|
|
|
// Startup logic to establish log monitoring
|
|
if (client.device.isConnected) {
|
|
if (client.device.os.includes('iOS')) {
|
|
watcher = addFileWatcherForiOSCrashLogs(
|
|
client.device.serial,
|
|
reportCrash,
|
|
);
|
|
} else {
|
|
startAndroidCrashWatcher(client, reportCrash);
|
|
}
|
|
}
|
|
|
|
client.onDestroy(() => {
|
|
watcher
|
|
?.then((watcher) => watcher?.close())
|
|
.catch((e) =>
|
|
console.error(
|
|
'[crash_reporter] FSWatcher failed resoving on destroy:',
|
|
e,
|
|
),
|
|
);
|
|
});
|
|
|
|
return {
|
|
reportCrash,
|
|
crashes,
|
|
selectedCrash,
|
|
openInLogs(callstack: string) {
|
|
client.selectPlugin('DeviceLogs', callstack);
|
|
},
|
|
os: client.device.os,
|
|
copyCrashToClipboard(callstack: string) {
|
|
client.writeTextToClipboard(callstack);
|
|
},
|
|
createPaste(callstack: string) {
|
|
client.createPaste(callstack);
|
|
},
|
|
isFB: client.isFB,
|
|
clearCrashes() {
|
|
crashes.set([]);
|
|
selectedCrash.set(undefined);
|
|
},
|
|
};
|
|
}
|
|
|
|
export {Crashes as Component} from './Crashes';
|