Files
flipper/desktop/app/src/ui/components/searchable/Searchable.tsx
Michel Weststrate 966d748ace Some fixes in rendering legacy plugins
Summary:
Some exploratory testing on all iOS and Android plugins, to see how they behave inside Sandy, and fixed some layout glitches (some were also present without Sandy)

General fixes:
* Introduced some niceties like searchbox resizing properly, and toolbars wrapping automatically in Sandy, rather than buttons becoming invisible
* Containers don't grow anymore by default, but take size of contents
* ScrollContainer child is now a Layout.Vertical. Layout.Vertical should be used as default container everywhere (e.g. Tabs, Panels) in the future
* Fixed layout issue if a split container had only 1 visible child
* DetailsSidebar now scrolls vertically by default
* Details sidebar would sometimes render content in-place rather than in the reserved area
* AppSelector dropdown and Plugin list will now properly ellipse (...) if there is not enough space

Plugin fixes:
* Long database / table names in Database plugin would break layout

Also fixes https://github.com/facebook/flipper/issues/1611

Reviewed By: passy

Differential Revision: D24454188

fbshipit-source-id: c60c867270900a1d4f28587d47067c6ec1072ede
2020-10-22 09:41:11 -07:00

555 lines
17 KiB
TypeScript

/**
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @format
*/
import {Filter} from '../filter/types';
import {TableColumns} from '../table/types';
import {PureComponent} from 'react';
import Toolbar from '../Toolbar';
import Input from '../Input';
import {colors} from '../colors';
import Text from '../Text';
import FlexBox from '../FlexBox';
import Glyph from '../Glyph';
import FilterToken from './FilterToken';
import styled from '@emotion/styled';
import {debounce} from 'lodash';
import ToggleButton from '../ToggleSwitch';
import React from 'react';
import Layout from '../Layout';
import {theme} from '../../../sandy-chrome/theme';
const SearchBar = styled(Toolbar)({
height: 42,
padding: 6,
});
SearchBar.displayName = 'Searchable:SearchBar';
export const SearchBox = styled(FlexBox)<{isInvalidInput?: boolean}>(
(props) => {
return {
flex: `1 0 0`,
minWidth: 150,
height: 30,
backgroundColor: colors.white,
borderRadius: '999em',
border: `1px solid ${
!props.isInvalidInput ? colors.light15 : colors.red
}`,
alignItems: 'center',
paddingLeft: 4,
};
},
);
SearchBox.displayName = 'Searchable:SearchBox';
export const SearchInput = styled(Input)<{
focus?: boolean;
regex?: boolean;
isValidInput?: boolean;
}>((props) => ({
border: props.focus ? '1px solid black' : 0,
...(props.regex ? {fontFamily: 'monospace'} : {}),
padding: 0,
fontSize: '1em',
flexGrow: 1,
height: 'auto',
lineHeight: '100%',
marginLeft: 2,
marginRight: 8,
width: '100%',
color: props.regex && !props.isValidInput ? colors.red : colors.black,
'&::-webkit-input-placeholder': {
color: colors.placeholder,
fontWeight: 300,
},
}));
SearchInput.displayName = 'Searchable:SearchInput';
const Clear = styled(Text)({
position: 'absolute',
right: 6,
top: '50%',
marginTop: -9,
fontSize: 16,
width: 17,
height: 17,
borderRadius: 999,
lineHeight: '15.5px',
textAlign: 'center',
backgroundColor: 'rgba(0,0,0,0.1)',
color: colors.white,
display: 'block',
'&:hover': {
backgroundColor: 'rgba(0,0,0,0.15)',
},
});
Clear.displayName = 'Searchable:Clear';
export const SearchIcon = styled(Glyph)({
marginRight: 3,
marginLeft: 3,
marginTop: -1,
minWidth: 16,
});
SearchIcon.displayName = 'Searchable:SearchIcon';
const Actions = styled(Layout.Horizontal)({
marginLeft: 8,
});
Actions.displayName = 'Searchable:Actions';
export type SearchableProps = {
addFilter: (filter: Filter) => void;
searchTerm: string;
filters: Array<Filter>;
allowRegexSearch?: boolean;
allowContentSearch?: boolean;
regexEnabled?: boolean;
contentSearchEnabled?: boolean;
};
type Props = {
placeholder?: string;
actions: React.ReactNode;
tableKey: string;
columns?: TableColumns;
onFilterChange: (filters: Array<Filter>) => void;
defaultFilters: Array<Filter>;
clearSearchTerm: boolean;
defaultSearchTerm: string;
allowRegexSearch: boolean;
allowContentSearch: boolean;
};
type State = {
filters: Array<Filter>;
focusedToken: number;
searchTerm: string;
hasFocus: boolean;
regexEnabled: boolean;
contentSearchEnabled: boolean;
compiledRegex: RegExp | null | undefined;
};
function compileRegex(s: string): RegExp | null {
try {
return new RegExp(s);
} catch (e) {
return null;
}
}
/**
* Higher-order-component that allows adding a searchbar on top of the wrapped
* component. See SearchableManagedTable for usage with a table.
*/
export default function Searchable(
Component: React.ComponentType<any>,
): React.ComponentType<any> {
return class extends PureComponent<Props, State> {
static displayName = `Searchable(${Component.displayName})`;
static defaultProps = {
placeholder: 'Search...',
clearSearchTerm: false,
};
state: State = {
filters: this.props.defaultFilters || [],
focusedToken: -1,
searchTerm: this.props.defaultSearchTerm ?? '',
hasFocus: false,
regexEnabled: false,
contentSearchEnabled: false,
compiledRegex: null,
};
_inputRef: HTMLInputElement | undefined | null;
componentDidMount() {
window.document.addEventListener('keydown', this.onKeyDown);
const {defaultFilters} = this.props;
let savedState:
| {
filters: Array<Filter>;
regexEnabled?: boolean;
contentSearchEnabled?: boolean;
searchTerm?: string;
}
| undefined;
if (this.getTableKey()) {
try {
savedState = JSON.parse(
window.localStorage.getItem(this.getPersistKey()) || 'null',
);
} catch (e) {
window.localStorage.removeItem(this.getPersistKey());
}
}
if (savedState) {
if (defaultFilters != null) {
// merge default filter with persisted filters
const savedStateFilters = savedState.filters;
defaultFilters.forEach((defaultFilter) => {
const filterIndex = savedStateFilters.findIndex(
(f) => f.key === defaultFilter.key,
);
const savedDefaultFilter = savedStateFilters[filterIndex];
if (filterIndex > -1 && savedDefaultFilter.type === 'enum') {
if (defaultFilter.type === 'enum') {
savedDefaultFilter.enum = defaultFilter.enum;
}
const filters = new Set(
savedDefaultFilter.enum.map((filter) => filter.value),
);
savedStateFilters[
filterIndex
].value = savedDefaultFilter.value.filter((value) =>
filters.has(value),
);
}
});
}
const searchTerm = this.props.clearSearchTerm
? this.props.defaultSearchTerm
: savedState.searchTerm || this.state.searchTerm;
this.setState({
searchTerm: searchTerm,
filters: savedState.filters || this.state.filters,
regexEnabled: savedState.regexEnabled || this.state.regexEnabled,
contentSearchEnabled:
savedState.contentSearchEnabled || this.state.contentSearchEnabled,
compiledRegex: compileRegex(searchTerm),
});
}
}
componentDidUpdate(prevProps: Props, prevState: State) {
if (
this.getTableKey() &&
(prevState.searchTerm !== this.state.searchTerm ||
prevState.regexEnabled != this.state.regexEnabled ||
prevState.contentSearchEnabled != this.state.contentSearchEnabled ||
prevState.filters !== this.state.filters)
) {
window.localStorage.setItem(
this.getPersistKey(),
JSON.stringify({
searchTerm: this.state.searchTerm,
filters: this.state.filters,
regexEnabled: this.state.regexEnabled,
contentSearchEnabled: this.state.contentSearchEnabled,
}),
);
if (this.props.onFilterChange != null) {
this.props.onFilterChange(this.state.filters);
}
} else {
let mergedFilters = this.state.filters;
if (prevProps.defaultFilters !== this.props.defaultFilters) {
mergedFilters = [...this.state.filters];
this.props.defaultFilters.forEach((defaultFilter: Filter) => {
const filterIndex = mergedFilters.findIndex(
(f: Filter) => f.key === defaultFilter.key,
);
if (filterIndex > -1) {
mergedFilters[filterIndex] = defaultFilter;
} else {
mergedFilters.push(defaultFilter);
}
});
}
let newSearchTerm = this.state.searchTerm;
if (
prevProps.defaultSearchTerm !== this.props.defaultSearchTerm ||
prevProps.defaultFilters !== this.props.defaultFilters
) {
newSearchTerm = this.props.defaultSearchTerm ?? '';
}
this.setState({
filters: mergedFilters,
searchTerm: newSearchTerm,
});
}
}
componentWillUnmount() {
window.document.removeEventListener('keydown', this.onKeyDown);
}
getTableKey = (): string | null | undefined => {
if (this.props.tableKey) {
return this.props.tableKey;
} else if (this.props.columns) {
// if we have a table, we are using it's colums to uniquely identify
// the table (in case there is more than one table rendered at a time)
return (
'TABLE_COLUMNS_' +
Object.keys(this.props.columns).join('_').toUpperCase()
);
}
};
onKeyDown = (e: KeyboardEvent) => {
const ctrlOrCmd = (e: KeyboardEvent) =>
(e.metaKey && process.platform === 'darwin') ||
(e.ctrlKey && process.platform !== 'darwin');
if (e.key === 'f' && ctrlOrCmd(e) && this._inputRef) {
e.preventDefault();
if (this._inputRef) {
this._inputRef.focus();
}
} else if (e.key === 'Escape' && this._inputRef) {
this._inputRef.blur();
this.setState({searchTerm: ''});
} else if (e.key === 'Backspace' && this.hasFocus()) {
const lastFilter = this.state.filters[this.state.filters.length - 1];
if (
this.state.focusedToken === -1 &&
this.state.searchTerm === '' &&
this._inputRef &&
lastFilter &&
(lastFilter.type !== 'enum' || !lastFilter.persistent)
) {
this._inputRef.blur();
this.setState({focusedToken: this.state.filters.length - 1});
} else {
this.removeFilter(this.state.focusedToken);
}
} else if (
e.key === 'Delete' &&
this.hasFocus() &&
this.state.focusedToken > -1
) {
this.removeFilter(this.state.focusedToken);
} else if (e.key === 'Enter' && this.hasFocus() && this._inputRef) {
this.matchTags(this._inputRef.value, true);
this.setState({searchTerm: ''});
}
};
onChangeSearchTerm = (e: React.ChangeEvent<HTMLInputElement>) => {
this.setState({
searchTerm: e.target.value,
compiledRegex: compileRegex(e.target.value),
});
this.matchTags(e.target.value, false);
};
matchTags = debounce((searchTerm: string, matchEnd: boolean) => {
const filterPattern = matchEnd
? /([a-z]\w*[!]?[:=]\S+)($|\s)/gi
: /([a-z]\w*[!]?[:=]\S+)\s/gi;
const match = searchTerm.match(filterPattern);
if (match && match.length > 0) {
match.forEach((filter: string) => {
const separator =
filter.indexOf(':') > filter.indexOf('=') ? ':' : '=';
let [key, ...values] = filter.split(separator);
let value = values.join(separator).trim();
let type: 'include' | 'exclude' | 'enum' = 'include';
// if value starts with !, it's an exclude filter
if (value.indexOf('!') === 0) {
type = 'exclude';
value = value.substring(1);
}
// if key ends with !, it's an exclude filter
if (key.indexOf('!') === key.length - 1) {
type = 'exclude';
key = key.slice(0, -1);
}
this.addFilter({
type,
key,
value,
});
});
searchTerm = searchTerm.replace(filterPattern, '');
}
}, 200);
setInputRef = (ref: HTMLInputElement | null) => {
this._inputRef = ref;
};
addFilter = (filter: Filter) => {
const filterIndex = this.state.filters.findIndex(
(f) => f.key === filter.key,
);
if (filterIndex > -1) {
const filters = [...this.state.filters];
const defaultFilter: Filter = this.props.defaultFilters?.[filterIndex];
const filter = filters[filterIndex];
if (
defaultFilter != null &&
defaultFilter.type === 'enum' &&
filter.type === 'enum'
) {
filter.enum = defaultFilter.enum;
}
this.setState({filters});
// filter for this key already exists
return;
}
// persistent filters are always at the front
const filters =
filter.type === 'enum' && filter.persistent === true
? [filter, ...this.state.filters]
: this.state.filters.concat(filter);
this.setState({
filters,
focusedToken: -1,
});
};
removeFilter = (index: number) => {
const filters = this.state.filters.filter((_, i) => i !== index);
const focusedToken = -1;
this.setState({filters, focusedToken}, () => {
if (this._inputRef) {
this._inputRef.focus();
}
});
};
replaceFilter = (index: number, filter: Filter) => {
const filters = [...this.state.filters];
filters.splice(index, 1, filter);
this.setState({filters});
};
onInputFocus = () =>
this.setState({
focusedToken: -1,
hasFocus: true,
});
onInputBlur = () =>
setTimeout(
() =>
this.setState({
hasFocus: false,
}),
100,
);
onTokenFocus = (focusedToken: number) => this.setState({focusedToken});
onTokenBlur = () => this.setState({focusedToken: -1});
onRegexToggled = () => {
this.setState({
regexEnabled: !this.state.regexEnabled,
compiledRegex: compileRegex(this.state.searchTerm),
});
};
onContentSearchToggled = () => {
this.setState({
contentSearchEnabled: !this.state.contentSearchEnabled,
});
};
hasFocus = (): boolean => {
return this.state.focusedToken !== -1 || this.state.hasFocus;
};
clear = () =>
this.setState({
filters: this.state.filters.filter(
(f) => f.type === 'enum' && f.persistent === true,
),
searchTerm: '',
});
getPersistKey = () => `SEARCHABLE_STORAGE_KEY_${this.getTableKey() || ''}`;
render() {
const {placeholder, actions, ...props} = this.props;
return (
<Layout.Top>
<SearchBar position="top" key="searchbar">
<SearchBox tabIndex={-1}>
<SearchIcon
name="magnifying-glass"
color={colors.macOSTitleBarIcon}
size={16}
/>
{this.state.filters.map((filter, i) => (
<FilterToken
key={`${filter.key}:${filter.type}`}
index={i}
filter={filter}
focused={i === this.state.focusedToken}
onFocus={this.onTokenFocus}
onDelete={this.removeFilter}
onReplace={this.replaceFilter}
onBlur={this.onTokenBlur}
/>
))}
<SearchInput
placeholder={placeholder}
onChange={this.onChangeSearchTerm}
value={this.state.searchTerm}
ref={this.setInputRef}
onFocus={this.onInputFocus}
onBlur={this.onInputBlur}
isValidInput={
this.state.regexEnabled
? this.state.compiledRegex !== null
: true
}
regex={Boolean(
this.state.regexEnabled && this.state.searchTerm,
)}
/>
{(this.state.searchTerm || this.state.filters.length > 0) && (
<Clear onClick={this.clear}>&times;</Clear>
)}
</SearchBox>
{this.props.allowRegexSearch ? (
<ToggleButton
toggled={this.state.regexEnabled}
onClick={this.onRegexToggled}
label={'Regex'}
/>
) : null}
{this.props.allowContentSearch ? (
<ToggleButton
toggled={this.state.contentSearchEnabled}
onClick={this.onContentSearchToggled}
label={'Contents'}
tooltip={
'Search the full item contents (warning: this can be quite slow)'
}
/>
) : null}
{actions != null && (
<Actions gap={theme.space.small}>{actions}</Actions>
)}
</SearchBar>
<Component
{...props}
key="table"
addFilter={this.addFilter}
searchTerm={this.state.searchTerm}
regexEnabled={this.state.regexEnabled}
contentSearchEnabled={this.state.contentSearchEnabled}
filters={this.state.filters}
/>
</Layout.Top>
);
}
};
}